-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: Add trace item stats endpoint #103217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
85ba071 to
559b978
Compare
a6d8a04 to
51327a6
Compare
| except NoProjects: | ||
| return Response({"data": []}) | ||
|
|
||
| stats_types = set(request.GET.getlist("statsType", default=["attributeDistributions"])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use a validator for these query parameters, e.g.
| serializer = OrganizationProfilingFlamegraphSerializer(data=request.GET) |
Abdkhan14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, we can iterate on anything that's missing
81853b0 to
0cce669
Compare
48b662c to
a517ddb
Compare
Adds an endpoint that is essentially a wrapper around the TraceItemStats endpoint.
This endpoint is meant to give you information about the shape of your data.
This will be used to return distributions. As we add more stats types, we will expose
them in this endpoint.