ref(seer onboarding): remove on_command_phrase CR trigger from repo settings and org options #105978

srest2021 · 2026-01-09T05:15:36Z

This table is less than 200 rows, so should be safe to skip doing it post-deployment.

cursor · 2026-01-09T20:02:18Z

Uncleaned org options can propagate invalid triggers to new repos

Low Severity

The migration removes on_command_phrase from existing RepositorySettings but does not clean up organization options (sentry:default_code_review_triggers). If a new repository is created for an org that still has on_command_phrase in their org options, _maybe_auto_enable_code_review() in repository.py will propagate this value to the new RepositorySettings. When get_code_review_settings() is later called, it will raise a ValueError trying to convert "on_command_phrase" to the now-reduced CodeReviewTrigger enum. The PR discussion mentions manual cleanup of the ~5 affected orgs is planned, but if not completed before deployment, new repos for those orgs could trigger this error.

Additional Locations (1)

src/sentry/migrations/1016_remove_on_command_phrase_trigger.py#L10-L34

This has now been cleaned up by hand in US and DE.

-Original file line number
+Diff line change
@@ Expand Up / @@ -31,7 +31,7 @@ releases: 0004_cleanup_failed_safe_deletes @@
     replays: 0007_organizationmember_replay_access
-    sentry: 1015_backfill_self_hosted_sentry_app_emails
+    sentry: 1016_remove_on_command_phrase_trigger
     social_auth: 0003_social_auth_json_field
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -297,7 +297,6 @@ class OrganizationExamples: @@
                     "defaultAutofixAutomationTuning": AutofixAutomationTuningSettings.OFF,
                     "autoEnableCodeReview": True,
                     "defaultCodeReviewTriggers": [
-                        "on_command_phrase",
                         "on_ready_for_review",
                         "on_new_commit",
                     ],
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -725,7 +725,6 @@ class InsightModules(Enum): @@
     AUTO_ENABLE_CODE_REVIEW = False
     # Seer Org level default for code review triggers
     DEFAULT_CODE_REVIEW_TRIGGERS: list[str] = [
-        "on_command_phrase",
         "on_ready_for_review",
         "on_new_commit",
     ]
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -369,9 +369,7 @@ class OrganizationSerializer(BaseOrganizationSerializer): @@
         autoOpenPrs = serializers.BooleanField(required=False)
         autoEnableCodeReview = serializers.BooleanField(required=False)
         defaultCodeReviewTriggers = serializers.ListField(
-            child=serializers.ChoiceField(
-                choices=["on_command_phrase", "on_ready_for_review", "on_new_commit"]
-            ),
+            child=serializers.ChoiceField(choices=["on_ready_for_review", "on_new_commit"]),
             required=False,
             allow_empty=True,
             help_text="The default code review triggers for new repositories.",
@@ Expand Down @@

-Original file line number
+Diff line change
@@ -0,0 +1,76 @@
+    # Generated by Django 5.2.8 on 2026-01-08 18:18
+    import django.contrib.postgres.fields
+    from django.db import migrations, models
+    from django.db.backends.base.schema import BaseDatabaseSchemaEditor
+    from django.db.migrations.state import StateApps
+    from sentry.new_migrations.migrations import CheckedMigration
+    def remove_on_command_phrase_from_repository_settings(
+        apps: StateApps, schema_editor: BaseDatabaseSchemaEditor
+    ) -> None:
+        """Remove 'on_command_phrase' from RepositorySettings.code_review_triggers."""
+        RepositorySettings = apps.get_model("sentry", "RepositorySettings")
+        all_settings = list(RepositorySettings.objects.all())
+        updated_settings = []
+        for settings in all_settings:
+            if (
+                settings.code_review_triggers
+                and isinstance(settings.code_review_triggers, list)
+                and "on_command_phrase" in settings.code_review_triggers
+            ):
+                settings.code_review_triggers = [
+                    trigger
+                    for trigger in settings.code_review_triggers
+                    if trigger != "on_command_phrase"
+                ]
+                updated_settings.append(settings)
+        if updated_settings:
+            RepositorySettings.objects.bulk_update(updated_settings, fields=["code_review_triggers"])
+    class Migration(CheckedMigration):
+        # This flag is used to mark that a migration shouldn't be automatically run in production.
+        # This should only be used for operations where it's safe to run the migration after your
+        # code has deployed. So this should not be used for most operations that alter the schema
+        # of a table.
+        # Here are some things that make sense to mark as post deployment:
+        # - Large data migrations. Typically we want these to be run manually so that they can be
+        #   monitored and not block the deploy for a long period of time while they run.
+        # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+        #   run this outside deployments so that we don't block them. Note that while adding an index
+        #   is a schema change, it's completely safe to run the operation after the code has deployed.
+        # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
+        is_post_deployment = False
+        dependencies = [
+            ("sentry", "1015_backfill_self_hosted_sentry_app_emails"),
+        ]
+        operations = [
+            migrations.RunPython(
+                remove_on_command_phrase_from_repository_settings,
+                reverse_code=migrations.RunPython.noop,
+                hints={"tables": ["sentry_repositorysettings"]},
+            ),
+            migrations.AlterField(
+                model_name="repositorysettings",
+                name="code_review_triggers",
+                field=django.contrib.postgres.fields.ArrayField(
+                    base_field=models.CharField(
+                        choices=[
+                            ("on_new_commit", "on_new_commit"),
+                            ("on_ready_for_review", "on_ready_for_review"),
+                        ],
+                        max_length=32,
+                    ),
+                    default=list,
+                ),
+            ),
+        ]

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ref(seer onboarding): remove on_command_phrase CR trigger from repo settings and org options #105978

Uh oh!

Diff view

Diff view

There are no files selected for viewing

srest2021 Jan 9, 2026

Uh oh!

Uh oh!

cursor bot Jan 9, 2026

Uh oh!

srest2021 Jan 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

-Original file line number
+Diff line change
@@ Expand Up / @@ -11,7 +11,6 @@ @@
     class CodeReviewTrigger(StrEnum):
-        ON_COMMAND_PHRASE = "on_command_phrase"
         ON_NEW_COMMIT = "on_new_commit"
         ON_READY_FOR_REVIEW = "on_ready_for_review"
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -11,7 +11,6 @@ @@
     from sentry.integrations.services.integration.model import RpcIntegration
     from sentry.models.organization import Organization
     from sentry.models.repository import Repository
-    from sentry.models.repositorysettings import CodeReviewTrigger
     from sentry.net.http import connection_from_url
     from sentry.seer.signed_seer_api import make_signed_seer_api_request
@@ Expand All / @@ -27,6 +26,19 @@ class ClientError(Exception): @@
         pass
+    class SeerCodeReviewTrigger(StrEnum):
+        """
+        Internal code review trigger type used for Seer flows.
+        This includes all user-configurable CodeReviewTrigger values, plus on_command_phrase,
+        which is always enabled and cannot be turned off by users.
+        """
+        ON_COMMAND_PHRASE = "on_command_phrase"
+        ON_NEW_COMMIT = "on_new_commit"
+        ON_READY_FOR_REVIEW = "on_ready_for_review"
     # These values need to match the value defined in the Seer API.
     class SeerEndpoint(StrEnum):
         # https://github.com/getsentry/seer/blob/main/src/seer/routes/automation_request.py#L57
@@ Expand Down Expand Up / @@ -194,7 +206,7 @@ def transform_webhook_to_codegen_request( @@
         organization: Organization,
         repo: Repository,
         target_commit_sha: str,
-        trigger: CodeReviewTrigger,
+        trigger: SeerCodeReviewTrigger,
     ) -> dict[str, Any] | None:
         """
         Transform a GitHub webhook payload into CodecovTaskRequest format for Seer.
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -14,7 +14,6 @@ @@
     from sentry.integrations.services.integration import RpcIntegration
     from sentry.models.organization import Organization
     from sentry.models.repository import Repository
-    from sentry.models.repositorysettings import CodeReviewTrigger
     from ..metrics import (
         CodeReviewErrorType,
@@ Expand All / @@ -24,7 +23,7 @@ @@
         record_webhook_handler_error,
         record_webhook_received,
     )
-    from ..utils import _get_target_commit_sha
+    from ..utils import SeerCodeReviewTrigger, _get_target_commit_sha
     from .config import get_direct_to_seer_gh_orgs
     logger = logging.getLogger(__name__)
@@ Expand Down Expand Up / @@ -153,6 +152,6 @@ def handle_issue_comment_event( @@
                 organization=organization,
                 repo=repo,
                 target_commit_sha=target_commit_sha,
-                trigger=CodeReviewTrigger.ON_COMMAND_PHRASE,
+                trigger=SeerCodeReviewTrigger.ON_COMMAND_PHRASE,
             )
             record_webhook_enqueued(github_event, github_event_action)

-Original file line number
+Diff line change
@@ Expand Up / @@ -55,7 +55,7 @@ def test_bulk_update_existing_settings(self) -> None: @@
             self.create_repository_settings(
                 repository=repo1,
                 enabled_code_review=False,
-                code_review_triggers=[CodeReviewTrigger.ON_COMMAND_PHRASE],
+                code_review_triggers=[CodeReviewTrigger.ON_READY_FOR_REVIEW],
             )
             self.create_repository_settings(
                 repository=repo2,
@@ Expand Down Expand Up @@
                 repository=repo1,
                 enabled_code_review=False,
                 code_review_triggers=[
-                    CodeReviewTrigger.ON_COMMAND_PHRASE,
+                    CodeReviewTrigger.ON_READY_FOR_REVIEW,
                     CodeReviewTrigger.ON_NEW_COMMIT,
                 ],
             )
@@ Expand All @@
             settings1 = RepositorySettings.objects.get(repository=repo1)
             assert settings1.enabled_code_review is True
-            assert settings1.code_review_triggers == ["on_command_phrase", "on_new_commit"]
+            assert settings1.code_review_triggers == ["on_ready_for_review", "on_new_commit"]
             settings2 = RepositorySettings.objects.get(repository=repo2)
             assert settings2.enabled_code_review is True
@@ Expand All @@
             self.create_repository_settings(
                 repository=repo1,
                 enabled_code_review=True,
-                code_review_triggers=[CodeReviewTrigger.ON_COMMAND_PHRASE],
+                code_review_triggers=[CodeReviewTrigger.ON_NEW_COMMIT],
             )
             self.create_repository_settings(
                 repository=repo2,
@@ Expand Down @@

-Original file line number
+Diff line change
@@ -0,0 +1,43 @@
+    from sentry.models.repositorysettings import RepositorySettings
+    from sentry.testutils.cases import TestMigrations
+    class RemoveOnCommandPhraseTriggerTest(TestMigrations):
+        migrate_from = "1015_backfill_self_hosted_sentry_app_emails"
+        migrate_to = "1016_remove_on_command_phrase_trigger"
+        def setup_initial_state(self) -> None:
+            org = self.create_organization()
+            self.project1 = self.create_project(organization=org)
+            self.repo1 = self.create_repo(project=self.project1, name="org/repo1")
+            self.repo_settings1 = RepositorySettings.objects.create(
+                repository=self.repo1,
+                enabled_code_review=True,
+                code_review_triggers=["on_command_phrase", "on_ready_for_review", "on_new_commit"],
+            )
+            self.project2 = self.create_project(organization=org)
+            self.repo2 = self.create_repo(project=self.project2, name="org/repo2")
+            self.repo_settings2 = RepositorySettings.objects.create(
+                repository=self.repo2,
+                enabled_code_review=True,
+                code_review_triggers=["on_ready_for_review", "on_new_commit"],
+            )
+            self.project3 = self.create_project(organization=org)
+            self.repo3 = self.create_repo(project=self.project3, name="org/repo3")
+            self.repo_settings3 = RepositorySettings.objects.create(
+                repository=self.repo3, enabled_code_review=True
+            )
+        def test(self) -> None:
+            repo_settings = RepositorySettings.objects.get(id=self.repo_settings1.id)
+            assert repo_settings.code_review_triggers == ["on_ready_for_review", "on_new_commit"]
+            assert "on_command_phrase" not in repo_settings.code_review_triggers
+            repo_settings = RepositorySettings.objects.get(id=self.repo_settings2.id)
+            assert repo_settings.code_review_triggers == ["on_ready_for_review", "on_new_commit"]
+            assert "on_command_phrase" not in repo_settings.code_review_triggers
+            repo_settings = RepositorySettings.objects.get(id=self.repo_settings3.id)
+            assert repo_settings.code_review_triggers == []

-Original file line number
+Diff line change
@@ Expand Up / @@ -11,7 +11,7 @@ @@
     class TestCodeReviewSettings(TestCase):
         def test_initialization(self) -> None:
-            triggers = [CodeReviewTrigger.ON_COMMAND_PHRASE, CodeReviewTrigger.ON_NEW_COMMIT]
+            triggers = [CodeReviewTrigger.ON_READY_FOR_REVIEW, CodeReviewTrigger.ON_NEW_COMMIT]
             settings = CodeReviewSettings(enabled=True, triggers=triggers)
             assert settings.enabled is True
@@ Expand All @@
                 repository=self.repo,
                 enabled_code_review=True,
                 code_review_triggers=[
-                    CodeReviewTrigger.ON_COMMAND_PHRASE.value,
+                    CodeReviewTrigger.ON_NEW_COMMIT.value,
                     CodeReviewTrigger.ON_READY_FOR_REVIEW.value,
                 ],
             )
@@ Expand All @@
             assert settings.enabled is True
             assert len(settings.triggers) == 2
-            assert CodeReviewTrigger.ON_COMMAND_PHRASE in settings.triggers
+            assert CodeReviewTrigger.ON_NEW_COMMIT in settings.triggers
             assert CodeReviewTrigger.ON_READY_FOR_REVIEW in settings.triggers
         def test_get_code_review_settings_converts_string_triggers_to_enum(self) -> None:
@@ Expand Down @@

Uh oh!

ref(seer onboarding): remove on_command_phrase CR trigger from repo settings and org options #105978

Uh oh!

ref(seer onboarding): remove on_command_phrase CR trigger from repo settings and org options #105978

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

srest2021 Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot Jan 9, 2026

Choose a reason for hiding this comment

Uncleaned org options can propagate invalid triggers to new repos

Uh oh!

srest2021 Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!