bugfix: Exclude "matched 2 out of 25" in the oneOf rule (#36)

Author: pboos

openapi-validation-core/src/main/java/com/getyourguide/openapi/validation/core/exclusions/InternalViolationExclusions.java

@@ -13,9 +13,16 @@ public boolean isExcluded(OpenApiViolation violation) {
         return falsePositive404(violation)
             || falsePositive400(violation)
             || customViolationExclusions.isExcluded(violation)
-            // If it matches more than 1, then we don't want to log a validation error
-            || violation.getMessage().matches(
-            ".*\\[Path '[^']+'] Instance failed to match exactly one schema \\(matched [1-9][0-9]* out of \\d\\).*");
+            || oneOfMatchesMoreThanOneSchema(violation);
+    }
+
+    private static boolean oneOfMatchesMoreThanOneSchema(OpenApiViolation violation) {
+        return (
+            "validation.response.body.schema.oneOf".equals(violation.getRule())
+                || "validation.request.body.schema.oneOf".equals(violation.getRule())
+            )
+            && violation.getMessage()
+            .matches(".*Instance failed to match exactly one schema \\(matched [1-9][0-9]* out of \\d+\\).*");
     }
 
     private boolean falsePositive404(OpenApiViolation violation) {

openapi-validation-core/src/test/java/com/getyourguide/openapi/validation/core/exclusions/InternalViolationExclusionsTest.java

@@ -55,9 +55,20 @@ public void testWhenInstanceFailedToMatchExactlyOneThenViolationExcluded() {
         when(customViolationExclusions.isExcluded(any())).thenReturn(false);
 
         checkViolationExcluded(OpenApiViolation.builder()
+            .rule("validation.response.body.schema.oneOf")
             .message("[Path '/v1/endpoint'] Instance failed to match exactly one schema (matched 2 out of 4)").build());
     }
 
+    @Test
+    public void testWhenInstanceFailedToMatchExactlyOneWithOneOf24ThenViolationExcluded() {
+        when(customViolationExclusions.isExcluded(any())).thenReturn(false);
+
+        checkViolationExcluded(OpenApiViolation.builder()
+            .rule("validation.request.body.schema.oneOf")
+            .message("[Path '/v1/endpoint'] Instance failed to match exactly one schema (matched 2 out of 24)")
+            .build());
+    }
+
     @Test
     public void testWhen404ResponseWithApiPathNotSpecifiedThenViolationExcluded() {
         when(customViolationExclusions.isExcluded(any())).thenReturn(false);