Skip to content

Commit 62d4463

Browse files
authored
Merge pull request #42 from getyourguide/prepare-release
Prepare first release 🥳
2 parents 0a9a6c5 + c4baa57 commit 62d4463

6 files changed

Lines changed: 10 additions & 10 deletions

File tree

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
* @getyourguide/tp
1+
* @getyourguide/iOS

CONTRIBUTING.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ Leverage the [shared spmgraph xcscheme](./.swiftpm/xcode/xcshareddata/xcschemes/
1616
- Update the arguments with the path to your Package.swift
1717
- **Do not commit** such changes
1818

19+
The spmgraph config package depends on spmgraph itself, and by default uses the latest release. Update the reference, in `Sources/SPMGraphConfigSetup/Resources/Package.txt`, to your working branch in order to have `spmgraph` changes take effect in the spmgraph config part
20+
1921
## Pull Request Process
2022

2123
- Aim to keep pull requests scoped to one feature to ease review

Sources/SPMGraphConfigSetup/Resources/Package.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ let package = Package(
1717
),
1818
],
1919
dependencies: [
20-
// TODO: Change it to HTTP when made public
21-
// TODO: Automate updating the revision based on the matching release
20+
// From `0.0.8` so that it always automatically picks and uses the latest release
21+
// When developing it should be updated to the working branch
2222
.package(
23-
url: "git@github.com:getyourguide/spmgraph.git",
24-
revision: "f70a8f6d35ac40e4875d1822c36ddc15e0ca27ab"
23+
url: "https://github.com/getyourguide/spmgraph.git",
24+
from: "0.0.8"
2525
),
2626
// - Pinned to the the Swift 6.2 development / Xcode 16.3
2727
// It auto exports SwiftToolsSupport, so no need to directly depend it 🙏

Sources/SPMGraphExecutable/SPMGraph.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ struct SPMGraph: AsyncParsableCommand {
6363
discussion: """
6464
Visualization, Selective testing, and Linting of a Package.swift dependency graph
6565
""",
66-
version: "0.0.8",
66+
version: "1.0.0",
6767
subcommands: [
6868
Config.self,
6969
Load.self,

Sources/SPMGraphExecutable/Subcommands/Tests.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ struct TestsArguments: ParsableArguments {
2626
name: [.customLong("files"), .customLong("changedFiles")],
2727
help: "Optional list of changed files. Otherwise git versioning is used. It supports both absolute and relative paths"
2828
)
29-
var changedFiles: [String] = [] // TODO: Change to AbsolutePath
29+
var changedFiles: [String] = []
3030

3131
@Option(
3232
name: [.customLong("baseBranch"), .customLong("branch"), .short],
@@ -50,8 +50,6 @@ struct TestsArguments: ParsableArguments {
5050

5151
@OptionGroup
5252
var config: SPMGraphConfigArguments
53-
54-
// TODO: Review if gitDir options is needed - generally git is in the root dir of the root Package
5553
}
5654

5755
struct Tests: AsyncParsableCommand {

Sources/SPMGraphTests/SPMGraphTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public struct SPMGraphTestsInput {
3636
/// Base branch to compare the changes against
3737
let baseBranch: String
3838
/// The output mode
39-
let outputMode: SPMGraphTests.OutputMode // TODO: Check if it make sense in the SPMGraphConfig fle
39+
let outputMode: SPMGraphTests.OutputMode
4040
/// Enables support for including UITest targets on selecting testing. It looks for a `uiTestsDependencies.json` in the temporary directory,
4141
/// reads it, and checks if any of the UITest targets dependencies are affected, if so, it includes them in the list of test targets to run.
4242
///

0 commit comments

Comments
 (0)