Commit 85f7572
authored
Treat an unchanged map/list component as wire-compatible in diff (#119)
wireCompatibleScalars recursed into map and list types requiring both components
to be wire-compatible, but had no equality short-circuit. An unchanged component
that is not a member of a wire-compatible scalar group (e.g. a string map key)
returned false, dragging the whole verdict to incompatible. So a genuinely
wire-safe map value widening such as map<string,int32> -> map<string,int64>
was reported as an Error in Wire mode, failing CI on a safe change.
Short-circuit identical components to wire-compatible.1 parent 2e9775c commit 85f7572
2 files changed
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
261 | 261 | | |
262 | 262 | | |
263 | 263 | | |
| 264 | + | |
264 | 265 | | |
265 | 266 | | |
266 | 267 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
157 | 171 | | |
158 | 172 | | |
159 | 173 | | |
| |||
0 commit comments