-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Replace computer monitor on homepage #2105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
assets/sass/front-page.scss
Outdated
|
|
||
| &:hover { | ||
| background-image: linear-gradient(#1a7e84, #165b60); | ||
| transform: translateY(-1px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this effect. To me it would feel more natural if the button moves down on hover. But I think I would prefer a highlighted border or something (I haven't decided yet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can just change the background colour instead, I think that's more in line with what the other buttons on the site do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit tricky to find hover background colours that work both in dark mode and light mode so I just removed the hover effect
b509051 to
6512c40
Compare
|
Going to try to fix the Playwright tests and merge this today. |
Co-authored-by: Marie Claire LeBlanc Flanagan <[email protected]>
The name of the install link changed and many of the links were removed. Update the tests to reflect that.
68079c2 to
a9cdd38
Compare
|
Hi there! Just a quick personal note: The design refresh really looks nice and it is good that some texts were updated. But what I don't like is that prominent "Github Repository" button below the download-button. IMHO already enough people confuse "git" with "github" (and/or think it'd be a synonym). Why not label it "Source Code" again, or "Source Code Repository" or so. |
|
@themilkman IMHO already enough people confuse open source for the thing where you tell others to implement your wishes. Why not open a Pull Request or so. |
This replaces the computer monitor on the homepage (and the links below it) with a single box.
You can see it in action here: https://jvns.github.io/git-scm.com/
I'm not totally sure about the "GitHub Repository" link, since it says elsewhere that technically the GitHub repo is a "mirror", but I think it is an official mirror and it's the most convenient way (at least for me) to view the current version of the source code.
I've removed the links below the monitor. Here's the new way to access the removed links, open to hearing that they should be made more prominent.
I expect this has the same issues with the screenshot not matching as #2088, haven't dealt with that yet.
Also I need to run the WCAG checker on this contrast in dark mode, not sure it's high enough.