Skip to content

Commit daf953f

Browse files
authored
Merge pull request #19404 from MathiasVP/cleanup-PropagateFlowConfig
Shared: Use `isSink/1` in `PropagateFlowConfig`
2 parents d784473 + b91a2cc commit daf953f

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll

+6-2
Original file line numberDiff line numberDiff line change
@@ -484,10 +484,14 @@ module MakeModelGenerator<
484484
}
485485

486486
predicate isSink(DataFlow::Node sink, FlowState state) {
487+
// Sinks are provided by `isSink/1`
488+
none()
489+
}
490+
491+
predicate isSink(DataFlow::Node sink) {
487492
sink instanceof ReturnNodeExt and
488493
not isOwnInstanceAccessNode(sink) and
489-
not exists(captureQualifierFlow(getAsExprEnclosingCallable(sink))) and
490-
(state instanceof TaintRead or state instanceof TaintStore)
494+
not exists(captureQualifierFlow(getAsExprEnclosingCallable(sink)))
491495
}
492496

493497
predicate isAdditionalFlowStep(

0 commit comments

Comments
 (0)