Skip to content

Data flow: Move more logic into DataFlowImplCommon#18113

Merged
hvitved merged 2 commits intogithub:mainfrom
hvitved:dataflow/more-common
Dec 2, 2024
Merged

Data flow: Move more logic into DataFlowImplCommon#18113
hvitved merged 2 commits intogithub:mainfrom
hvitved:dataflow/more-common

Conversation

@hvitved
Copy link
Copy Markdown
Contributor

@hvitved hvitved commented Nov 26, 2024

Follows up on #17300.

@hvitved hvitved force-pushed the dataflow/more-common branch 4 times, most recently from e33db0a to d113a20 Compare November 27, 2024 07:50
@hvitved hvitved force-pushed the dataflow/more-common branch from d113a20 to 7402276 Compare November 27, 2024 08:03
@github-actions github-actions Bot added the C++ label Nov 27, 2024
@hvitved hvitved marked this pull request as ready for review November 27, 2024 09:02
@hvitved hvitved requested a review from a team as a code owner November 27, 2024 09:02
@hvitved hvitved requested review from aschackmull and removed request for a team November 27, 2024 09:02
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 27, 2024
Copy link
Copy Markdown
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hvitved hvitved merged commit 012ea4b into github:main Dec 2, 2024
@hvitved hvitved deleted the dataflow/more-common branch December 2, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ DataFlow Library no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants