Skip to content

Commit c3d41ec

Browse files
authored
Merge pull request #40 from github/lsep/update-dependencies
Update build dependencies, update octokit request
2 parents c38bf6f + 6ad0a2b commit c3d41ec

File tree

6 files changed

+1694
-10999
lines changed

6 files changed

+1694
-10999
lines changed

.github/workflows/dependency-submission-example.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@ jobs:
1212
- name: 'Checkout Repository'
1313
uses: actions/checkout@v3
1414
- uses: actions/setup-node@v3
15+
# As of 2023-02-22, the ubuntu-latest image uses npm v8.3.1. This version
16+
# has a bug that prevents loading dependency-submission-toolkit in the
17+
# 'example/' project. npm v8.4.1 (same version in Codespace created on
18+
# same date) is known to work. Not pinned to latest to avoid
19+
# reproducibility issues.
20+
- run: npm install [email protected] -g
1521
- name: Install NPM dependencies
1622
run: npm ci
1723
- name: Run all NPM build/test actions

.github/workflows/test.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,14 @@ jobs:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- uses: actions/checkout@v2
17+
# As of 2023-02-22, the ubuntu-latest image uses npm v8.3.1. This version
18+
# has a bug that prevents loading dependency-submission-toolkit in the
19+
# 'example/' project. npm v8.4.1 (same version in Codespace created on
20+
# same date) is known to work. Not pinned to latest to avoid
21+
# reproducibility issues.
22+
- run: npm install [email protected] -g
1723
- name: Install NPM dependencies
1824
run: npm ci
25+
- run: npm install
1926
- name: Run all NPM build/test actions
2027
run: npm rebuild && npm run all

example/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"name": "npm-dependency-submission-example",
2+
"name": "@github/npm-dependency-submission-example",
33
"version": "1.0.0",
4-
"description": "Example using the Dependency Submission Toolkit and npm list",
4+
"description": "[UNPUBLISHED PACKAGE!] Example using the Dependency Submission Toolkit and npm list",
55
"main": "index.ts",
66
"dependencies": {
77
"@github/dependency-submission-toolkit": "file:../",

0 commit comments

Comments
 (0)