-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST API endpoints for pull requests should mention Allow GitHub Actions to create and approve pull requests
#36525
Comments
Thanks for raising this, @jsoref Before I triage it: just to run it by you, would it make more sense for the error message to return a link to https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#preventing-github-actions-from-creating-or-approving-pull-requests instead of https://docs.github.com/rest/pulls/pulls#create-a-pull-request ? |
@subatoi oh, yeah, I think so. As you already know that the user is GitHub-actions and that it has generic Certainly, if you're willing to special case the error message, that'd be great. Thinking about how the code has to work, it really should already be in a special case, so, yes please! |
Note that that the doc might need some adjusting to say "if you were directed here by an error, it's because you need to toggle this feature or use a dedicated account instead". |
Just to set expectations appropriately, I can only make recommendations about the error message, but either way I agree this could be improved. Since it relates to the REST docs, I'm going to transfer this to an internal issue (all of the comments here will be noted). If it's feasible to change the error message URL—it might need to be shortened—I'll make that recommendation, but otherwise I agree we could look at adding a section here instead, per your original recommendation. Many thanks for bringing this to our attention |
Thank you for opening this issue! Updates to this documentation must be made internally. I have copied your issue to an internal issue, so I will close this issue. |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#create-a-pull-request
What part(s) of the article would you like to see updated?
Add a subsection
github-actions
Possibly that just links to https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#preventing-github-actions-from-creating-or-approving-pull-requests
Additional information
GitHub workflows that use
gh pr ...
or the api equivalent trigger this error:Which points to the above document but the above document makes no mention of this knob.
The text was updated successfully, but these errors were encountered: