Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform support got reverted to version 1.8 #36528

Closed
nightpool opened this issue Feb 26, 2025 · 6 comments
Closed

Terraform support got reverted to version 1.8 #36528

nightpool opened this issue Feb 26, 2025 · 6 comments
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Comments

@nightpool
Copy link

#35614 updated the docs to indicate support for Terraform 1.10, but apparently #35726 and 6dc3409 reverted this change for half of the files that were affected, and prod now indicates that only version 1.8 is supported: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#:~:text=Terraform,%3E%3D%200.13%2C%20%3C%3D%201.8

https://github.com/github/docs/blame/b3a70c47caf985dff51de0dfd96129f68878fd7e/content/code-security/dependabot/working-with-dependabot/dependabot-options-reference.md#L399

This change is material, because when I was evaluating Dependabot for updating dependencies on our Terraform repo, the fact that it only supported a very outdated Terraform version was the main reason I chose to go with a different service (Renovate) instead. Please make sure the service team does a better job of keeping these docs up to date!

Copy link

welcome bot commented Feb 26, 2025

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added triage Do not begin working on this issue until triaged by the team labels Feb 26, 2025
@subatoi subatoi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 27, 2025
@subatoi
Copy link
Contributor

subatoi commented Feb 27, 2025

Hi @nightpool and thanks for bringing this to our attention

reverted this change for half of the files that were affected

In reality that table was just never updated—the refactor in 6dc3409#diff-8a61d3ca6c8ee8c2e4471bfb611f789df6be3516eb5f46421601fb20987f8da5R402 only moved some content around; it didn't revert the change to the table in the reusable in #35614

Nevertheless, that table (that does not use the reusable) does need updating, and we'll create a fix for this internally. I'll leave this issue open for the moment to track it. Thanks again for raising this!

@nightpool
Copy link
Author

@subatoi when #35614 was merged the reusable table was used in configuration-options-for-the-dependabot.yml-file.md:

https://github.com/github/docs/blob/d95363bd04852e360d8a1ce9a9bec4bbc4298796/content/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file.md?plain#L68-L81

When configuration-options-for-the-dependabot.yml-file.md was renamed/refactored into dependabot-options-reference.md in 6dc3409 it removed the reference to the reusable and went back to hard-coding the table:

6dc3409#diff-cbce3eccf5f535f4502688e4253bd81c56841099d6feb271228f9ed403b25efcL53
6dc3409#diff-8a61d3ca6c8ee8c2e4471bfb611f789df6be3516eb5f46421601fb20987f8da5R402

@subatoi
Copy link
Contributor

subatoi commented Feb 27, 2025

You're quite correct; I was wrong about that. Nevertheless, the team has it on their radar to fix as soon as possible

@nightpool
Copy link
Author

Yep! Just wanted to highlight that it seems like there's a deeper process failure here (maybe related to the split private/public repos? maybe related to merge conflicts?) beyond just missing an update location that should be considered in the team's retrospective for this issue

@subatoi
Copy link
Contributor

subatoi commented Feb 28, 2025

This has been fixed now, so I'll go ahead and close this

Thank you again for bringing this to our attention—I've passed your feedback on and we've made a change to an internal process as a safeguard against this happening again. In this case, it was just unfortunate timing with a necessary large reorg of some content, but nonetheless, we'll do our best to make sure it's not repeated. Thank you again!

@subatoi subatoi closed this as completed Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

3 participants
@nightpool @subatoi and others