-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform support got reverted to version 1.8 #36528
Comments
Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Hi @nightpool and thanks for bringing this to our attention
In reality that table was just never updated—the refactor in 6dc3409#diff-8a61d3ca6c8ee8c2e4471bfb611f789df6be3516eb5f46421601fb20987f8da5R402 only moved some content around; it didn't revert the change to the table in the reusable in #35614 Nevertheless, that table (that does not use the reusable) does need updating, and we'll create a fix for this internally. I'll leave this issue open for the moment to track it. Thanks again for raising this! |
@subatoi when #35614 was merged the reusable table was used in When 6dc3409#diff-cbce3eccf5f535f4502688e4253bd81c56841099d6feb271228f9ed403b25efcL53 docs/content/code-security/dependabot/working-with-dependabot/dependabot-options-reference.md Line 402 in 6dc3409
|
You're quite correct; I was wrong about that. Nevertheless, the team has it on their radar to fix as soon as possible |
Yep! Just wanted to highlight that it seems like there's a deeper process failure here (maybe related to the split private/public repos? maybe related to merge conflicts?) beyond just missing an update location that should be considered in the team's retrospective for this issue |
This has been fixed now, so I'll go ahead and close this Thank you again for bringing this to our attention—I've passed your feedback on and we've made a change to an internal process as a safeguard against this happening again. In this case, it was just unfortunate timing with a necessary large reorg of some content, but nonetheless, we'll do our best to make sure it's not repeated. Thank you again! |
#35614 updated the docs to indicate support for Terraform 1.10, but apparently #35726 and 6dc3409 reverted this change for half of the files that were affected, and prod now indicates that only version 1.8 is supported: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#:~:text=Terraform,%3E%3D%200.13%2C%20%3C%3D%201.8
https://github.com/github/docs/blame/b3a70c47caf985dff51de0dfd96129f68878fd7e/content/code-security/dependabot/working-with-dependabot/dependabot-options-reference.md#L399
This change is material, because when I was evaluating Dependabot for updating dependencies on our Terraform repo, the fact that it only supported a very outdated Terraform version was the main reason I chose to go with a different service (Renovate) instead. Please make sure the service team does a better job of keeping these docs up to date!
The text was updated successfully, but these errors were encountered: