[Schema Consistency] Schema Consistency Check - 2026-05-30 #35882
Closed
Replies: 1 comment
-
|
This discussion has been marked as outdated by Schema Consistency Checker. A newer discussion is available at Discussion #36077. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
main@ adab887)strict) and one low-confidence strategy (additionalProperties) was dropped as unverifiable rather than reported speculativelyAll seven items below were independently reproduced in the current tree this run. None are net-new regressions, but each remains unfixed and is safe to action.
Critical / High-Priority Issues
1. Three top-level schema fields have ZERO curated documentation (Schema ↔ Docs)
check-for-updates,disable-model-invocation, andrun-install-scriptsare all valid properties inpkg/parser/schemas/main_workflow_schema.jsonbut appear in no curated doc underdocs/src/content/docs/(excluding the auto-generatedfrontmatter-full.md). Users can only discover them by reading the generated reference.2.
applyTois an undocumented escape hatch with a stale code comment (Schema ↔ Parser)pkg/parser/include_processor.go:267still lists"applyTo": truein thevalidFieldsallowlist.pkg/parser/schema_utilities.go:14comments thatapplyTois "now validated by the schema" — butapplyTois not a property inmain_workflow_schema.json(jq '.properties | has("applyTo")'→false).applyTohas zero curated-doc mentions.The comment is factually wrong, and the field is silently accepted by the parser while the schema would reject it under
additionalProperties: false.Documentation Gaps
3. Two schema descriptions link to non-existent doc anchors (Schema ↔ Docs)
The
check-for-updatesandrun-install-scriptsdescriptions both link toreference/frontmatter/#<field>anchors, butdocs/src/content/docs/reference/frontmatter.mdhas no heading that slugifies to either anchor. Both links are dead.Anchor verification details
check-for-updatesfrontmatter/#check-for-updatesrun-install-scriptsfrontmatter/#run-install-scriptsSchema Improvements Needed
4. Deprecated fields lack the JSON Schema
deprecatedflag (Schema internals)Two fields are described as deprecated/legacy in prose but carry neither
"deprecated": truenor anx-deprecation-message, so tooling/IDEs cannot surface the deprecation:inline-sub-agents— description starts "Deprecated switch for inline sub-agent support...",.deprecated=nullrate-limit— description starts "Legacy alias for 'user-rate-limit'...",.deprecated=null5. Dead
$def:templatable_integer(Schema internals, low)$defs.templatable_integeris defined but never$ref'd anywhere in the schema (0 references), whereas its siblingtemplatable_booleanis referenced. Either wire it up where integer fields are templatable or remove it.Parser Updates Required
6. Legacy
rate-limitalias emits no user-visible deprecation warning (Parser ↔ Docs)pkg/workflow/role_checks.go:301logsroleLog.Print("Extracted legacy rate-limit configuration")— a debug-level logger line, not a user-facing compile warning. By contrastpkg/workflow/compiler_validators.go:344emits an EXPERIMENTAL warning foruser-rate-limit. The deprecated alias should warn users to migrate; today it is silently accepted.7.
SharedWorkflowForbiddenFieldscontains dead entries (Schema internals, low)pkg/constants/constants.golists"command"(line 328) and"roles"(line 336) inSharedWorkflowForbiddenFields, but neither is a top-level schema property (jq '.properties | has("command")'/has("roles")→false). Since the top-level schema isadditionalProperties: false, these would already be rejected — the entries are dead/defensive. Harmless, but worth pruning or commenting as intentional.Recommendations
check-for-updates,disable-model-invocation,run-install-scripts(fixes rejig docs #1 and the dead anchors in Add workflow: githubnext/agentics/weekly-research #3).schema_utilities.go:14and decide whetherapplyToshould be a real schema property or removed fromvalidFields(Add workflow: githubnext/agentics/weekly-research #2)."deprecated": true(+ optionalx-deprecation-message) toinline-sub-agentsandrate-limit(Add workflow: githubnext/agentics/weekly-research #4); remove or wire uptemplatable_integer(Add workflow: githubnext/agentics/weekly-research #5).rate-limitdebug log to a real deprecation warning, mirroring theuser-rate-limitexperimental warning (add cli flag to guard dropping a agentic workflow instructinos file #6).command/rolesentries inSharedWorkflowForbiddenFields(Weekly Research Report: AI Workflow Automation Landscape and Market Opportunities - August 2025 #7).Strategy Performance
strictcorrectly excluded; 1 strategyadditionalPropertiesdropped as unverifiable due toonbeing aoneOfcomposite that breaks plain jq paths)strictfalse-positive caveat (strategy-10), and theoneOf-traversal caveat (strategy-18).Next Steps
check-for-updates,disable-model-invocation,run-install-scripts(fixes dead anchors too)schema_utilities.go:14comment and resolveapplyTostatusdeprecatedflags toinline-sub-agentsandrate-limitrate-limit$deftemplatable_integerand prune deadSharedWorkflowForbiddenFieldsentriesReferences: §26676862620
Beta Was this translation helpful? Give feedback.
All reactions