Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Number of items answered" metric in the overview table #312

Open
zkoppert opened this issue Jun 10, 2024 · 4 comments
Open

Add "Number of items answered" metric in the overview table #312

zkoppert opened this issue Jun 10, 2024 · 4 comments
Labels
enhancement New feature or request keep

Comments

@zkoppert
Copy link
Member

Is your feature request related to a problem?

When running the action on discussions, it would be nice to be able to see the "Number of items answered" metric in the overview table

Describe the solution you'd like

If discussion is found in the search_query then count the number of discussions marked as answered and display the count in the markdown and json output.

Describe alternatives you've considered

No response

Additional context

No response

Copy link

github-actions bot commented Jul 2, 2024

This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 2, 2024
@zkoppert zkoppert added keep and removed Stale labels Jul 2, 2024
@mark-mxwl
Copy link

Hi @zkoppert! I've been reviewing this issue, and would be happy to help out. Before diving in, I'd like to clarify a few things to make sure I fully understand the requirements for the feature:

  1. After reviewing the discussion query schema, I assume that the field to include in the condition is answerChosenAt. Ex.: If the value is not None, add to the count.
  2. I assume that the logic would be implemented in issue_metrics.py, and the following modules would need to be updated to account for the changes: markdown_writer.py, json_writer.py, and any relevant test scripts.
  3. Is there a particular position in the table where you'd like Number of items answered: to appear?

Any thoughts, suggestions, or guidance you could offer would be greatly appreciated!

@Piedone
Copy link

Piedone commented Feb 16, 2025

As a user of this action, I'd comment on the 3rd question: I'd add it after "Number of items that remain open", i.e. here:

Image

For an example of the current output on an active project see: OrchardCMS/OrchardCore#17442.

@mark-mxwl
Copy link

Thanks, @Piedone! Appreciate your input, as well as the sample output. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keep
Projects
None yet
Development

No branches or pull requests

3 participants