Pub git2_hooks::create_hook only for feature "test-utils"

git2_hooks::create_hook is a function used in tests, which panics on common
errors. It can't really be moved into git2-testing, as it depends on
git2_hooks::hookspath::HookPaths.

In order to avoid accidental use, move the function into
git2_hooks::test_utils[_priv] and only publish it as git2_hooks::test_utils
if feature = "test-utils" is enabled.

Author: Naseschwarz

Diff for: Cargo.lock

@@ -18,7 +18,7 @@ dirs = "5.0"
 easy-cast = "0.5"
 fuzzy-matcher = "0.3"
 git2 = "0.20"
-git2-hooks = { path = "../git2-hooks", version = ">=0.4" }
+git2-hooks = { path = "../git2-hooks", version = ">=0.4", features = ["test-utils"] }
 gix = { version = "0.70.0", default-features = false, features = [
     "max-performance",
     "revision",
@@ -39,6 +39,7 @@ url = "2.5"
 
 [dev-dependencies]
 env_logger = "0.11"
+git2-testing = { path = "../git2-testing" }
 invalidstring = { path = "../invalidstring", version = "0.1" }
 pretty_assertions = "1.4"
 serial_test = "3.2"

Diff for: asyncgit/Cargo.toml

@@ -12,8 +12,15 @@ license = "MIT"
 categories = ["development-tools"]
 keywords = ["git"]
 
+[features]
+default = []
+
+# test-utils publishes fns that are useful for testing. These may panic on common errors.
+test-utils = ["git2-testing"]
+
 [dependencies]
 git2 = ">=0.17"
+git2-testing = { path = "../git2-testing", optional = true }
 log = "0.4"
 shellexpand = "3.1"
 thiserror = "2.0"

Diff for: git2-hooks/Cargo.toml

@@ -30,7 +30,7 @@ mod hookspath;
 use std::{
 	fs::File,
 	io::{Read, Write},
-	path::{Path, PathBuf},
+	path::PathBuf,
 };
 
 pub use error::HooksError;
@@ -80,23 +80,6 @@ impl HookResult {
 	}
 }
 
-/// helper method to create git hooks programmatically (heavy used in unittests)
-///
-/// # Panics
-/// Panics if hook could not be created
-pub fn create_hook(
-	r: &Repository,
-	hook: &str,
-	hook_script: &[u8],
-) -> PathBuf {
-	let hook = HookPaths::new(r, None, hook).unwrap();
-
-	let path = hook.hook.clone();
-
-	create_hook_in_path(&hook.hook, hook_script);
-
-	path
-}
 /// Git hook: `commit_msg`
 ///
 /// This hook is documented here <https://git-scm.com/docs/githooks#_commit_msg>.
@@ -216,12 +199,45 @@ pub fn hooks_prepare_commit_msg(
 	Ok(res)
 }
 
+#[cfg(any(feature = "test-utils", test))]
+mod test_utils_priv {
+	use crate::hookspath::HookPaths;
+	use git2::Repository;
+	use std::path::PathBuf;
+
+	/// helper method to create git hooks programmatically (heavy used in unittests)
+	///
+	/// # Panics
+	/// Panics if hook could not be created
+	pub fn create_hook(
+		r: &Repository,
+		hook: &str,
+		hook_script: &[u8],
+	) -> PathBuf {
+		let hook = HookPaths::new(r, None, hook).unwrap();
+
+		let path = hook.hook.clone();
+
+		git2_testing::create_hook_in_path(&hook.hook, hook_script);
+
+		path
+	}
+}
+
+#[cfg(feature = "test-utils")]
+pub mod test_utils {
+	pub use crate::test_utils_priv::create_hook;
+}
+
 #[cfg(test)]
 mod tests {
 	use super::*;
-	use git2_testing::{repo_init, repo_init_bare};
+	use git2_testing::{
+		create_hook_in_path, repo_init, repo_init_bare,
+	};
 	use pretty_assertions::assert_eq;
 	use tempfile::TempDir;
+	use super::test_utils_priv::*;
 
 	#[test]
 	fn test_smoke() {