Fix decoding timezone #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgo has an inconsistent behaviour with times indeed (see this: #go-mgo#13 and this: go-mgo/mgo#362). A UTC time value which is stored as UTC in Mongo, when you fetch it, mgo decodes it to the local time. I fixed it with returning the time in UTC. So, anyone can after convert it to whatever timezone they want.
Author
|
Hi @inancgumus, thanks for the contribution - I'm currently out of the country for a few days so sorry for the delay. Would you mind re-targetting this PR to development and ensuring the existing tests pass? You should also include a test case for the issue at hand if possible. I've opened #20 to make the PR process clearer when I'm back in the office. Thanks for helping! |
|
Hi @inancgumus Is there any progress on this? This fork may be OK due to the changes in #13 |
Author
|
Hi @domodwyer Sorry, I've been busy and couldn't done anything yet. |
|
Hi @inancgumus I'm doing a bit of cleaning and will close this PR as it's not confirmed there's an issue in this fork (#13 may cover it). If you find the time I'll be happy to re-open! Dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mgo has an inconsistent behaviour with times indeed (see #13 and go-mgo/mgo#362).
When you fetch UTC time value from MongoDB, mgo decodes it to the local time. I fixed it with returning the time in UTC instead. So, anyone can convert it to their timezone if they want.