Clear conditions

Author: AdrienClairembault

src/Glpi/Form/Form.php

@@ -56,6 +56,7 @@
 use Glpi\Form\Condition\FormData;
 use Glpi\Form\Condition\QuestionData;
 use Glpi\Form\Condition\SectionData;
+use Glpi\Form\Condition\VisibilityStrategy;
 use Glpi\Form\Destination\FormDestination;
 use Glpi\Form\Destination\FormDestinationTicket;
 use Glpi\Form\QuestionType\QuestionTypeInterface;
@@ -374,6 +375,13 @@ private function prepareInput(array $input): array
             unset($input['_submit_button_conditions']);
         }
 
+        if (
+            isset($input['submit_button_visibility_strategy'])
+            && $input['submit_button_visibility_strategy'] == VisibilityStrategy::ALWAYS_VISIBLE->value
+        ) {
+            $input['submit_button_conditions'] = json_encode([]);
+        }
+
         return $input;
     }
 

tests/functional/Glpi/Form/FormTest.php

@@ -43,6 +43,10 @@
 use Glpi\Form\AccessControl\FormAccessControl;
 use Glpi\Form\AnswersHandler\AnswersHandler;
 use Glpi\Form\Comment;
+use Glpi\Form\Condition\LogicOperator;
+use Glpi\Form\Condition\Type;
+use Glpi\Form\Condition\ValueOperator;
+use Glpi\Form\Condition\VisibilityStrategy;
 use Glpi\Form\Destination\FormDestination;
 use Glpi\Form\Destination\FormDestinationChange;
 use Glpi\Form\Destination\FormDestinationProblem;
@@ -811,4 +815,29 @@ public function testDefinedTabs(
         // Assert: the tabs should match the expected data
         $this->assertEquals($expected_tabs, $tabs);
     }
+
+    public function testSubmitConditionsDataIsCleanedWhenStrategyIsReset(): void
+    {
+        // Arrange: create a form with some conditions
+        $builder = new FormBuilder();
+        $builder->addQuestion("My question", QuestionTypeShortText::class);
+        $builder->setSubmitButtonVisibility(VisibilityStrategy::VISIBLE_IF, [
+            [
+                'logic_operator' => LogicOperator::AND,
+                'item_name'      => "My question",
+                'item_type'      => Type::QUESTION,
+                'value_operator' => ValueOperator::EQUALS,
+                'value'          => "Yes",
+            ],
+        ]);
+        $form = $this->createForm($builder);
+
+        // Act: reset the visibility strategy
+        $form = $this->updateItem(Form::class, $form->getID(), [
+            'submit_button_visibility_strategy' => VisibilityStrategy::ALWAYS_VISIBLE->value
+        ]);
+
+        // Assert: the conditions should be deleted
+        $this->assertEmpty($form->getConfiguredConditionsData());
+    }
 }