Clear conditions

src/Glpi/Form/Comment.php

@@ -169,6 +169,8 @@ private function prepareInput(array $input): array
             unset($input['_conditions']);
         }
 
+        $input = $this->removeSavedConditionsIfAlwaysVisible($input);
+
         return $input;
     }
 

src/Glpi/Form/Condition/ConditionableCreationInterface.php

@@ -37,4 +37,7 @@
 interface ConditionableCreationInterface extends ConditionableInterface
 {
     public function getConfiguredCreationStrategy(): CreationStrategy;
+
+    // TODO: uncomment on main to prevent BC breaks
+    // protected function removeSavedConditionsIfAlwaysCreated(array $input): array;
 }

src/Glpi/Form/Condition/ConditionableCreationTrait.php

@@ -34,6 +34,8 @@
 
 namespace Glpi\Form\Condition;
 
+use function Safe\json_encode;
+
 trait ConditionableCreationTrait
 {
     use ConditionableTrait;
@@ -44,4 +46,19 @@ public function getConfiguredCreationStrategy(): CreationStrategy
         $strategy = CreationStrategy::tryFrom($strategy_value);
         return $strategy ?? CreationStrategy::ALWAYS_CREATED;
     }
+
+    protected function removeSavedConditionsIfAlwaysCreated(array $input): array
+    {
+        $strategy_field = 'creation_strategy';
+        $condition_field = $this->getConditionsFieldName();
+
+        if (
+            isset($input[$strategy_field])
+            && $input[$strategy_field] == CreationStrategy::ALWAYS_CREATED->value
+        ) {
+            $input[$condition_field] = json_encode([]);
+        }
+
+        return $input;
+    }
 }

src/Glpi/Form/Condition/ConditionableValidationTrait.php

@@ -34,6 +34,8 @@
 
 namespace Glpi\Form\Condition;
 
+use function Safe\json_encode;
+
 trait ConditionableValidationTrait
 {
     use ConditionableTrait {
@@ -76,4 +78,19 @@ public function getConfiguredValidationStrategy(): ValidationStrategy
         $strategy = ValidationStrategy::tryFrom($strategy_value);
         return $strategy ?? ValidationStrategy::NO_VALIDATION;
     }
+
+    protected function removeSavedConditionsIfNoValidation(array $input): array
+    {
+        $strategy_field = $this->getValidationStrategyFieldName();
+        $condition_field = $this->getValidationConditionsFieldName();
+
+        if (
+            isset($input[$strategy_field])
+            && $input[$strategy_field] == ValidationStrategy::NO_VALIDATION->value
+        ) {
+            $input[$condition_field] = json_encode([]);
+        }
+
+        return $input;
+    }
 }

src/Glpi/Form/Condition/ConditionableVisibilityInterface.php

@@ -49,4 +49,7 @@ public function getConfiguredVisibilityStrategy(): VisibilityStrategy;
      * @return string
      */
     public function getUUID(): string;
+
+    // TODO: uncomment on main to prevent BC breaks
+    // protected function removeSavedConditionsIfAlwaysVisible(array $input): array;
 }

src/Glpi/Form/Condition/ConditionableVisibilityTrait.php

@@ -34,6 +34,8 @@
 
 namespace Glpi\Form\Condition;
 
+use function Safe\json_encode;
+
 trait ConditionableVisibilityTrait
 {
     use ConditionableTrait;
@@ -56,4 +58,19 @@ public function getConfiguredVisibilityStrategy(): VisibilityStrategy
         $strategy = VisibilityStrategy::tryFrom($strategy_value);
         return $strategy ?? VisibilityStrategy::ALWAYS_VISIBLE;
     }
+
+    protected function removeSavedConditionsIfAlwaysVisible(array $input): array
+    {
+        $visibility_field = $this->getVisibilityStrategyFieldName();
+        $condition_field = $this->getConditionsFieldName();
+
+        if (
+            isset($input[$visibility_field])
+            && $input[$visibility_field] == VisibilityStrategy::ALWAYS_VISIBLE->value
+        ) {
+            $input[$condition_field] = json_encode([]);
+        }
+
+        return $input;
+    }
 }

src/Glpi/Form/Destination/FormDestination.php

@@ -284,6 +284,8 @@ public function prepareInput($input): array
             unset($input['_conditions']);
         }
 
+        $input = $this->removeSavedConditionsIfAlwaysCreated($input);
+
         return $input;
     }
 

src/Glpi/Form/Form.php

@@ -374,6 +374,8 @@ private function prepareInput(array $input): array
             unset($input['_submit_button_conditions']);
         }
 
+        $input = $this->removeSavedConditionsIfAlwaysVisible($input);
+
         return $input;
     }
 

src/Glpi/Form/Question.php

@@ -401,6 +401,9 @@ private function prepareInput(array $input): array
             }
         }
 
+        $input = $this->removeSavedConditionsIfAlwaysVisible($input);
+        $input = $this->removeSavedConditionsIfNoValidation($input);
+
         return $input;
     }
 

src/Glpi/Form/Section.php

@@ -144,6 +144,8 @@ private function prepareInput(array $input): array
             unset($input['_conditions']);
         }
 
+        $input = $this->removeSavedConditionsIfAlwaysVisible($input);
+
         return $input;
     }
 

tests/functional/Glpi/Form/CommentTest.php

@@ -0,0 +1,77 @@
+<?php
+
+/**
+ * ---------------------------------------------------------------------
+ *
+ * GLPI - Gestionnaire Libre de Parc Informatique
+ *
+ * http://glpi-project.org
+ *
+ * @copyright 2015-2025 Teclib' and contributors.
+ * @licence   https://www.gnu.org/licenses/gpl-3.0.html
+ *
+ * ---------------------------------------------------------------------
+ *
+ * LICENSE
+ *
+ * This file is part of GLPI.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ * ---------------------------------------------------------------------
+ */
+
+namespace tests\units\Glpi\Form;
+
+use DbTestCase;
+use Glpi\Form\Comment;
+use Glpi\Form\Condition\LogicOperator;
+use Glpi\Form\Condition\Type;
+use Glpi\Form\Condition\ValueOperator;
+use Glpi\Form\Condition\VisibilityStrategy;
+use Glpi\Form\QuestionType\QuestionTypeShortText;
+use Glpi\Tests\FormBuilder;
+use Glpi\Tests\FormTesterTrait;
+
+final class CommentTest extends DbTestCase
+{
+    use FormTesterTrait;
+
+    public function testConditionsDataAreCleanedWhenStrategyIsReset(): void
+    {
+        // Arrange: create a form with visibility conditions on a comment
+        $builder = new FormBuilder();
+        $builder->addQuestion("My question", QuestionTypeShortText::class);
+        $builder->addComment("My comment");
+        $builder->setCommentVisibility("My comment", VisibilityStrategy::VISIBLE_IF, [
+            [
+                'logic_operator' => LogicOperator::AND,
+                'item_name'      => "My question",
+                'item_type'      => Type::QUESTION,
+                'value_operator' => ValueOperator::EQUALS,
+                'value'          => "Yes",
+            ],
+        ]);
+        $form = $this->createForm($builder);
+
+        // Act: reset the comment's visibility strategy
+        $comment_id = $this->getCommentId($form, "My comment");
+        $comment = $this->updateItem(Comment::class, $comment_id, [
+            'visibility_strategy' => VisibilityStrategy::ALWAYS_VISIBLE->value,
+        ]);
+
+        // Assert: the conditions should be deleted
+        $this->assertEmpty($comment->getConfiguredConditionsData());
+    }
+}

tests/functional/Glpi/Form/Destination/FormDestinationTest.php

@@ -37,6 +37,10 @@
 use CommonGLPI;
 use DBmysql;
 use DbTestCase;
+use Glpi\Form\Condition\CreationStrategy;
+use Glpi\Form\Condition\LogicOperator;
+use Glpi\Form\Condition\Type;
+use Glpi\Form\Condition\ValueOperator;
 use Glpi\Form\Destination\FormDestination;
 use Glpi\Form\Destination\FormDestinationTicket;
 use Glpi\Form\Form;
@@ -153,6 +157,32 @@ public function testWarningsAreRendereredInTabContent()
         );
     }
 
+    public function testConditionsDataAreCleanedWhenStrategyIsReset(): void
+    {
+        // Arrange: create a form with creation conditions on a destination
+        $builder = new FormBuilder();
+        $builder->addQuestion("My question", QuestionTypeShortText::class);
+        $builder->setDestinationCondition("Ticket", CreationStrategy::CREATED_IF, [
+            [
+                'logic_operator' => LogicOperator::AND,
+                'item_name'      => "My question",
+                'item_type'      => Type::QUESTION,
+                'value_operator' => ValueOperator::EQUALS,
+                'value'          => "Yes",
+            ],
+        ]);
+        $form = $this->createForm($builder);
+
+        // Act: reset the destiantion's creation strategy
+        $destination_id = $this->getDestinationId($form, "Ticket");
+        $destination = $this->updateItem(FormDestination::class, $destination_id, [
+            'creation_strategy' => CreationStrategy::ALWAYS_CREATED->value,
+        ]);
+
+        // Assert: the conditions should be deleted
+        $this->assertEmpty($destination->getConfiguredConditionsData());
+    }
+
     private function createAndGetFormWithFourDestinations(): Form
     {
         $builder = new FormBuilder();

tests/functional/Glpi/Form/FormTest.php

@@ -43,6 +43,10 @@
 use Glpi\Form\AccessControl\FormAccessControl;
 use Glpi\Form\AnswersHandler\AnswersHandler;
 use Glpi\Form\Comment;
+use Glpi\Form\Condition\LogicOperator;
+use Glpi\Form\Condition\Type;
+use Glpi\Form\Condition\ValueOperator;
+use Glpi\Form\Condition\VisibilityStrategy;
 use Glpi\Form\Destination\FormDestination;
 use Glpi\Form\Destination\FormDestinationChange;
 use Glpi\Form\Destination\FormDestinationProblem;
@@ -811,4 +815,29 @@ public function testDefinedTabs(
         // Assert: the tabs should match the expected data
         $this->assertEquals($expected_tabs, $tabs);
     }
+
+    public function testSubmitConditionsDataAreCleanedWhenStrategyIsReset(): void
+    {
+        // Arrange: create a form with a condition on its submit button
+        $builder = new FormBuilder();
+        $builder->addQuestion("My question", QuestionTypeShortText::class);
+        $builder->setSubmitButtonVisibility(VisibilityStrategy::VISIBLE_IF, [
+            [
+                'logic_operator' => LogicOperator::AND,
+                'item_name'      => "My question",
+                'item_type'      => Type::QUESTION,
+                'value_operator' => ValueOperator::EQUALS,
+                'value'          => "Yes",
+            ],
+        ]);
+        $form = $this->createForm($builder);
+
+        // Act: reset the submit button's visibility strategy
+        $form = $this->updateItem(Form::class, $form->getID(), [
+            'submit_button_visibility_strategy' => VisibilityStrategy::ALWAYS_VISIBLE->value,
+        ]);
+
+        // Assert: the conditions should be deleted
+        $this->assertEmpty($form->getConfiguredConditionsData());
+    }
 }