Stop double flushing

Laurie Clark-Michalek · Laurie Clark-Michalek · commit be7a9b90e71f · 2017-01-03T21:09:41.000Z
diff --git a/middleware/compress.go b/middleware/compress.go
@@ -227,6 +227,7 @@ func (h *httpGenericWrapper) CloseNotify() <-chan bool {
 func (h *httpGenericWrapper) Flush() {
 	if f, ok := h.genericWrapper.inner.(http.Flusher); ok {
 		f.Flush()
+		return
 	}
 
 	h.genericWrapper.inner.Unwrap().(http.Flusher).Flush()
diff --git a/middleware/compress_18.go b/middleware/compress_18.go
@@ -39,6 +39,7 @@ func (h *http2GenericWrapper) CloseNotify() <-chan bool {
 func (h *http2GenericWrapper) Flush() {
 	if f, ok := h.genericWrapper.inner.(http.Flusher); ok {
 		f.Flush()
+		return
 	}
 
 	h.genericWrapper.inner.Unwrap().(http.Flusher).Flush()

Original file line number	Diff line number	Diff line change
`@@ -227,6 +227,7 @@ func (h *httpGenericWrapper) CloseNotify() <-chan bool {`
`227`	`227`	`func (h *httpGenericWrapper) Flush() {`
`228`	`228`	`if f, ok := h.genericWrapper.inner.(http.Flusher); ok {`
`229`	`229`	`f.Flush()`
	`230`	`+ return`
`230`	`231`	`}`
`231`	`232`
`232`	`233`	`h.genericWrapper.inner.Unwrap().(http.Flusher).Flush()`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ func (h *http2GenericWrapper) CloseNotify() <-chan bool {`
`39`	`39`	`func (h *http2GenericWrapper) Flush() {`
`40`	`40`	`if f, ok := h.genericWrapper.inner.(http.Flusher); ok {`
`41`	`41`	`f.Flush()`
	`42`	`+ return`
`42`	`43`	`}`
`43`	`44`
`44`	`45`	`h.genericWrapper.inner.Unwrap().(http.Flusher).Flush()`