Fix panic on signed empty commit message (go-gitea/gitea#6292) (#149)

zeripath · web-flow · commit 74d7c14dd4a3 · 2019-03-11T07:11:10.000Z
* Fix panic on signed empty commit message (go-gitea/gitea#6292)
diff --git a/repo_commit.go b/repo_commit.go
@@ -101,7 +101,11 @@ l:
 				sig, err := newGPGSignatureFromCommitline(data, (nextline+1)+sigindex, true)
 				if err == nil && sig != nil {
 					// remove signature from commit message
-					cm = cm[:sigindex-1]
+					if sigindex == 0 {
+						cm = ""
+					} else {
+						cm = cm[:sigindex-1]
+					}
 					commit.Signature = sig
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,11 @@ l:`
`101`	`101`	`sig, err := newGPGSignatureFromCommitline(data, (nextline+1)+sigindex, true)`
`102`	`102`	`if err == nil && sig != nil {`
`103`	`103`	`// remove signature from commit message`
`104`		`- cm = cm[:sigindex-1]`
	`104`	`+ if sigindex == 0 {`
	`105`	`+ cm = ""`
	`106`	`+ } else {`
	`107`	`+ cm = cm[:sigindex-1]`
	`108`	`+ }`
`105`	`109`	`commit.Signature = sig`
`106`	`110`	`}`
`107`	`111`	`}`