Fix JS error for "select" dropdown (#34743)

wxiaoguang · web-flow · commit 4cbb48255476 · 2025-06-17T19:19:08.000+08:00
Regression of recent dropdown filter change.
diff --git a/web_src/js/modules/fomantic/dropdown.ts b/web_src/js/modules/fomantic/dropdown.ts
@@ -72,10 +72,10 @@ function updateSelectionLabel(label: HTMLElement) {
 }
 
 function onAfterFiltered(this: any) {
-  const $dropdown = $(this);
+  const $dropdown = $(this).closest('.ui.dropdown'); // "this" can be the "ui dropdown" or "<select>"
   const hideEmptyDividers = $dropdown.dropdown('setting', 'hideDividers') === 'empty';
   const itemsMenu = $dropdown[0].querySelector('.scrolling.menu') || $dropdown[0].querySelector('.menu');
-  if (hideEmptyDividers) hideScopedEmptyDividers(itemsMenu);
+  if (hideEmptyDividers && itemsMenu) hideScopedEmptyDividers(itemsMenu);
 }
 
 // delegate the dropdown's template functions and callback functions to add aria attributes.

Original file line number	Diff line number	Diff line change
`@@ -72,10 +72,10 @@ function updateSelectionLabel(label: HTMLElement) {`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`function onAfterFiltered(this: any) {`
`75`		`- const $dropdown = $(this);`
	`75`	`+ const $dropdown = $(this).closest('.ui.dropdown'); // "this" can be the "ui dropdown" or "<select>"`
`76`	`76`	`const hideEmptyDividers = $dropdown.dropdown('setting', 'hideDividers') === 'empty';`
`77`	`77`	`const itemsMenu = $dropdown[0].querySelector('.scrolling.menu') \|\| $dropdown[0].querySelector('.menu');`
`78`		`- if (hideEmptyDividers) hideScopedEmptyDividers(itemsMenu);`
	`78`	`+ if (hideEmptyDividers && itemsMenu) hideScopedEmptyDividers(itemsMenu);`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`// delegate the dropdown's template functions and callback functions to add aria attributes.`