Allow Select/Omit for Generics Create, close #7638, #7633

Author: jinzhu

generics.go

@@ -39,7 +39,7 @@ type Interface[T any] interface {
 
 type CreateInterface[T any] interface {
 	ExecInterface[T]
-	// chain methods available at start; return ChainInterface
+	// chain methods available at start; Select/Omit keep CreateInterface to allow Create chaining
 	Scopes(scopes ...func(db *Statement)) ChainInterface[T]
 	Where(query interface{}, args ...interface{}) ChainInterface[T]
 	Not(query interface{}, args ...interface{}) ChainInterface[T]
@@ -48,8 +48,8 @@ type CreateInterface[T any] interface {
 	Offset(offset int) ChainInterface[T]
 	Joins(query clause.JoinTarget, on func(db JoinBuilder, joinTable clause.Table, curTable clause.Table) error) ChainInterface[T]
 	Preload(association string, query func(db PreloadBuilder) error) ChainInterface[T]
-	Select(query string, args ...interface{}) ChainInterface[T]
-	Omit(columns ...string) ChainInterface[T]
+	Select(query string, args ...interface{}) CreateInterface[T]
+	Omit(columns ...string) CreateInterface[T]
 	MapColumns(m map[string]string) ChainInterface[T]
 	Distinct(args ...interface{}) ChainInterface[T]
 	Group(name string) ChainInterface[T]
@@ -203,6 +203,18 @@ func (c createG[T]) Table(name string, args ...interface{}) CreateInterface[T] {
 	})}
 }
 
+func (c createG[T]) Select(query string, args ...interface{}) CreateInterface[T] {
+	return createG[T]{c.with(func(db *DB) *DB {
+		return db.Select(query, args...)
+	})}
+}
+
+func (c createG[T]) Omit(columns ...string) CreateInterface[T] {
+	return createG[T]{c.with(func(db *DB) *DB {
+		return db.Omit(columns...)
+	})}
+}
+
 func (c createG[T]) Set(assignments ...clause.Assigner) SetCreateOrUpdateInterface[T] {
 	return c.processSet(assignments...)
 }

tests/generics_test.go

@@ -69,6 +69,36 @@ func TestGenericsCreate(t *testing.T) {
 	if v := mapResult["user_name"]; fmt.Sprint(v) != user.Name {
 		t.Errorf("failed to find map results, got %v, err %v", mapResult, err)
 	}
+
+	selectOnly := User{Name: "GenericsCreateSelectOnly", Age: 99}
+	if err := gorm.G[User](DB).Select("name").Create(ctx, &selectOnly); err != nil {
+		t.Fatalf("failed to create with Select, got error: %v", err)
+	}
+
+	if selectOnly.ID == 0 {
+		t.Fatalf("no primary key found for select-only user: %v", selectOnly)
+	}
+
+	if stored, err := gorm.G[User](DB).Where("id = ?", selectOnly.ID).First(ctx); err != nil {
+		t.Fatalf("failed to reload select-only user, got error: %v", err)
+	} else if stored.Name != selectOnly.Name || stored.Age != 0 {
+		t.Errorf("unexpected select-only user state, got %#v", stored)
+	}
+
+	omitAge := User{Name: "GenericsCreateOmitAge", Age: 88}
+	if err := gorm.G[User](DB).Omit("age").Create(ctx, &omitAge); err != nil {
+		t.Fatalf("failed to create with Omit, got error: %v", err)
+	}
+
+	if omitAge.ID == 0 {
+		t.Fatalf("no primary key found for omit-age user: %v", omitAge)
+	}
+
+	if stored, err := gorm.G[User](DB).Where("id = ?", omitAge.ID).First(ctx); err != nil {
+		t.Fatalf("failed to reload omit-age user, got error: %v", err)
+	} else if stored.Name != omitAge.Name || stored.Age != 0 {
+		t.Errorf("unexpected omit-age user state, got %#v", stored)
+	}
 }
 
 func TestGenericsCreateInBatches(t *testing.T) {

tests/go.mod

@@ -12,7 +12,7 @@ require (
 	gorm.io/driver/postgres v1.6.0
 	gorm.io/driver/sqlite v1.6.0
 	gorm.io/driver/sqlserver v1.6.1
-	gorm.io/gorm v1.30.5
+	gorm.io/gorm v1.31.0
 )
 
 require (
@@ -31,9 +31,9 @@ require (
 	github.com/microsoft/go-mssqldb v1.9.3 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/tjfoc/gmsm v1.4.1 // indirect
-	golang.org/x/crypto v0.42.0 // indirect
+	golang.org/x/crypto v0.43.0 // indirect
 	golang.org/x/sync v0.17.0 // indirect
-	golang.org/x/text v0.29.0 // indirect
+	golang.org/x/text v0.30.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )