Improved handling client level SetError option and pointer option

Author: jeevatkm

client.go

@@ -78,7 +78,7 @@ type Client struct {
 	UserInfo   *User
 	Token      string
 	Cookies    []*http.Cookie
-	Error      interface{}
+	Error      reflect.Type
 	Debug      bool
 	Log        *log.Logger
 
@@ -354,7 +354,12 @@ func (c *Client) SetContentLength(l bool) *Client {
 //		resty.SetError(Error{})
 //
 func (c *Client) SetError(err interface{}) *Client {
-	c.Error = getPointer(err)
+	t := reflect.TypeOf(err)
+	if t.Kind() == reflect.Ptr {
+		c.Error = t.Elem()
+	} else {
+		c.Error = t
+	}
 	return c
 }
 
@@ -1050,9 +1055,9 @@ func getResponseBodyString(res *Response) string {
 }
 
 func getPointer(v interface{}) interface{} {
-	rv := reflect.ValueOf(v)
+	rv := reflect.TypeOf(v)
 	if rv.Kind() != reflect.Ptr {
-		return reflect.New(rv.Type()).Interface()
+		return reflect.New(rv).Interface()
 	}
 
 	return v

middleware.go

@@ -269,7 +269,7 @@ func parseResponseBody(c *Client, res *Response) (err error) {
 		if res.StatusCode() > 399 {
 			// global error interface
 			if res.Request.Error == nil && c.Error != nil {
-				res.Request.Error = c.Error
+				res.Request.Error = reflect.New(c.Error).Interface()
 			}
 
 			if res.Request.Error != nil {

resty.go

@@ -9,4 +9,4 @@ Package resty provides simple HTTP and REST client for Go inspired by Ruby rest-
 package resty
 
 // go-resty version no
-var Version = "0.2.1"
+var Version = "0.2.2"

resty_test.go

@@ -314,10 +314,12 @@ func TestPostXMLStructInvalidLogin(t *testing.T) {
 	ts := createPostServer(t)
 	defer ts.Close()
 
-	resp, err := dclr().
+	c := dc()
+	c.SetError(&AuthError{})
+
+	resp, err := c.R().
 		SetHeader(hdrContentTypeKey, "application/xml").
 		SetBody(User{Username: "testuser", Password: "testpass1"}).
-		SetError(&AuthError{}).
 		Post(ts.URL + "/login")
 
 	assertError(t, err)
@@ -405,7 +407,7 @@ func TestRequestBasicAuthFail(t *testing.T) {
 
 	c := dc()
 	c.SetTLSClientConfig(&tls.Config{InsecureSkipVerify: true}).
-		SetError(&AuthError{})
+		SetError(AuthError{})
 
 	resp, err := c.R().
 		SetBasicAuth("myuser", "basicauth1").
@@ -880,7 +882,7 @@ func TestClientOptions(t *testing.T) {
 
 	err := &AuthError{}
 	SetError(err)
-	if err != DefaultClient.Error {
+	if reflect.TypeOf(err) == DefaultClient.Error {
 		t.Error("SetError failed")
 	}