Skip to content

Commit 981bb3f

Browse files
vegetablechicken233xiyuliu
and
xiyuliu
authored
feat(enhancement): use AddEventListener check instead of OnMessage check (#989)
Co-authored-by: xiyuliu <[email protected]>
1 parent 575bf38 commit 981bb3f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

sse.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,9 @@ func (es *EventSource) Get() error {
343343
if isStringEmpty(es.url) {
344344
return fmt.Errorf("resty:sse: event source URL is required")
345345
}
346-
if _, found := es.onEvent[defaultEventName]; !found {
347-
return fmt.Errorf("resty:sse: OnMessage function is required")
346+
347+
if len(es.onEvent) == 0 {
348+
return fmt.Errorf("resty:sse: At least one OnMessage/AddEventListener func is required")
348349
}
349350

350351
// reset to begin

sse_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ func TestEventSourceCoverage(t *testing.T) {
339339

340340
es.SetURL("https://sse.dev/test")
341341
err2 := es.Get()
342-
assertEqual(t, "resty:sse: OnMessage function is required", err2.Error())
342+
assertEqual(t, "resty:sse: At least one OnMessage/AddEventListener func is required", err2.Error())
343343

344344
es.OnMessage(func(a any) {}, nil)
345345
es.SetURL("//res%20ty.dev")

0 commit comments

Comments
 (0)