From 2d8376edad4136abfa775d7d18256c315ccfdc15 Mon Sep 17 00:00:00 2001 From: xiyuliu Date: Fri, 21 Mar 2025 11:35:01 +0800 Subject: [PATCH 1/2] [refactor] use AddEventListener check instead of OnMessage check --- sse.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sse.go b/sse.go index 440cabe..ebfaf33 100644 --- a/sse.go +++ b/sse.go @@ -343,8 +343,9 @@ func (es *EventSource) Get() error { if isStringEmpty(es.url) { return fmt.Errorf("resty:sse: event source URL is required") } - if _, found := es.onEvent[defaultEventName]; !found { - return fmt.Errorf("resty:sse: OnMessage function is required") + + if len(es.onEvent) == 0 { + return fmt.Errorf("resty:sse: At least one OnMessage/AddEventListener func is required") } // reset to begin From 87dff8f53218124977b697ef1405f336ae37db69 Mon Sep 17 00:00:00 2001 From: xiyuliu Date: Sat, 22 Mar 2025 16:02:33 +0800 Subject: [PATCH 2/2] [chore] correct TestEventSourceCoverage function --- sse_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sse_test.go b/sse_test.go index f64be2b..4a71cf4 100644 --- a/sse_test.go +++ b/sse_test.go @@ -339,7 +339,7 @@ func TestEventSourceCoverage(t *testing.T) { es.SetURL("https://sse.dev/test") err2 := es.Get() - assertEqual(t, "resty:sse: OnMessage function is required", err2.Error()) + assertEqual(t, "resty:sse: At least one OnMessage/AddEventListener func is required", err2.Error()) es.OnMessage(func(a any) {}, nil) es.SetURL("//res%20ty.dev")