Skip to content

Commit 64c6a5b

Browse files
pd93andreynering
authored andcommitted
feat: update issue templates
1 parent 18cb66f commit 64c6a5b

File tree

5 files changed

+44
-17
lines changed

5 files changed

+44
-17
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,18 @@ name: Bug Report
33
about: Use this to report bugs and issues
44
---
55

6-
> Thanks for your bug report!
7-
>
8-
> Before submitting this issue, please make sure the same problem was
9-
> not already reported by someone else.
10-
>
11-
> Please describe the bug you're facing. Consider pasting example
12-
> Taskfiles showing how to reproduce the problem.
6+
<!--
7+
8+
Thanks for your bug report!
9+
10+
Before submitting this issue, please make sure the same problem was not
11+
already reported by someone else.
12+
13+
Please describe the bug you're facing. Consider pasting example Taskfiles
14+
showing how to reproduce the problem.
15+
16+
-->
1317

1418
- Task version:
15-
- Operating System:
19+
- Operating system:
20+
- Experiments enabled:

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,13 @@ name: Feature Request
33
about: Use this to make feature requests
44
---
55

6-
> Describe in detail what feature do you want to see in Task.
7-
> Give examples if possible.
8-
>
9-
> Please, search if this wasn't proposed before, and if this is more like an idea
10-
> than a strong feature request, consider opening a
11-
> [discussion](https://github.com/go-task/task/discussions) instead.
6+
<!--
7+
8+
Describe in detail what feature do you want to see in Task.
9+
Give examples if possible.
10+
11+
Please, search if this wasn't proposed before, and if this is more like an idea
12+
than a strong feature request, consider opening a
13+
[discussion](https://github.com/go-task/task/discussions) instead.
14+
15+
-->

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
#1194 by @deviantintegral).
77
- Added [experiments documentation](https://taskfile.dev/experiments) to the
88
website (#1198 by @pd93).
9+
- Deprecated `version: 2` schema. This will be removed in the next major release
10+
(#1197, #1198, #1199 by @pd93).
911

1012
## v3.25.0 - 2023-05-22
1113

setup.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,11 @@ func (e *Executor) doVersionChecks() error {
250250
*v = *e.Taskfile.Version
251251

252252
if v.LessThan(taskfile.V2) {
253-
return fmt.Errorf(`task: Taskfile versions prior to v2 are not supported anymore`)
253+
return fmt.Errorf(`task: version 1 schemas are no longer supported`)
254+
}
255+
256+
if v.LessThan(taskfile.V3) {
257+
e.Logger.Errf(logger.Yellow, "task: version 2 schemas are deprecated and will be removed in a future release\nSee https://github.com/go-task/task/issues/1197 for more details\n")
254258
}
255259

256260
// consider as equal to the greater version if round

task_test.go

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1371,15 +1371,27 @@ func TestDynamicVariablesShouldRunOnTheTaskDir(t *testing.T) {
13711371
tt.Run(t)
13721372
}
13731373

1374-
func TestDisplaysErrorOnUnsupportedVersion(t *testing.T) {
1374+
func TestDisplaysErrorOnVersion1Schema(t *testing.T) {
13751375
e := task.Executor{
13761376
Dir: "testdata/version/v1",
13771377
Stdout: io.Discard,
13781378
Stderr: io.Discard,
13791379
}
13801380
err := e.Setup()
13811381
require.Error(t, err)
1382-
assert.Equal(t, "task: Taskfile versions prior to v2 are not supported anymore", err.Error())
1382+
assert.Equal(t, "task: version 1 schemas are no longer supported", err.Error())
1383+
}
1384+
1385+
func TestDisplaysWarningOnVersion2Schema(t *testing.T) {
1386+
var buff bytes.Buffer
1387+
e := task.Executor{
1388+
Dir: "testdata/version/v2",
1389+
Stdout: io.Discard,
1390+
Stderr: &buff,
1391+
}
1392+
err := e.Setup()
1393+
require.NoError(t, err)
1394+
assert.Equal(t, "task: version 2 schemas are deprecated and will be removed in a future release\nSee https://github.com/go-task/task/issues/1197 for more details\n", buff.String())
13831395
}
13841396

13851397
func TestShortTaskNotation(t *testing.T) {

0 commit comments

Comments
 (0)