Regression: Builtin variables not resolved in included `vars` section

[Diaphteiros]

Description

Taskfile.yaml

version: 3

includes:
  shared:
    taskfile: common/Taskfile_library.yaml
    vars:
      CODE_DIRS: '{{.ROOT_DIR}}/pkg/...'

tasks:
  print:
    desc: Print the code dirs.
    cmds:
    - 'echo "Code dirs: {{.ROOT_DIR}}/pkg/..."'

common/Taskfile_library.yaml

version: 3

tasks:
  print:
    desc: Print the code dirs.
    cmds:
    - 'echo "Code dirs: {{.CODE_DIRS}}"'

With version v3.42.0:

task print
task: [print] echo "Code dirs: /var/folders/b8/g43jjlg51gs4h13yf49sjmjm0000gn/T/tmp.fjWVHCzUTO/pkg/..."
Code dirs: /var/folders/b8/g43jjlg51gs4h13yf49sjmjm0000gn/T/tmp.fjWVHCzUTO/pkg/...

task shared:print
task: [shared:print] echo "Code dirs: /var/folders/b8/g43jjlg51gs4h13yf49sjmjm0000gn/T/tmp.fjWVHCzUTO/pkg/..."
Code dirs: /var/folders/b8/g43jjlg51gs4h13yf49sjmjm0000gn/T/tmp.fjWVHCzUTO/pkg/...

With version v3.43.*:

task print
task: [print] echo "Code dirs: /var/folders/b8/g43jjlg51gs4h13yf49sjmjm0000gn/T/tmp.fjWVHCzUTO/pkg/..."
Code dirs: /var/folders/b8/g43jjlg51gs4h13yf49sjmjm0000gn/T/tmp.fjWVHCzUTO/pkg/...

task shared:print
task: [shared:print] echo "Code dirs: /pkg/..."
Code dirs: /pkg/...

As you can see, everything was working perfectly fine before and now the ROOT_DIR variable is resolved to the empty string in the CODE_DIRS: '{{.ROOT_DIR}}/pkg/...' line.

Version

v3.43.*

Operating system

macOS

Experiments Enabled

None

[sandro-meier]

We can confirm this with the latest update that was rolled out this morning via snap on Ubuntu 20.04 and 22.04.

Available versions on snap are:

task  v3.42.0  232  latest/stable  andreynering  classic
task  v3.43.2  239  latest/stable  andreynering  disabled,classic

v3.42.0 works, 3.42.2 shows the above mentioned problem.

[fechu]

A git bisect between v3.42.0 and current main reveals that the regressing commit is: f0414f1 #2113

[fechu]

I did a preliminary investigation and see the following issue: The change in #2113 replaces variables in the include section at the time when the task file is read. However, all the special variables (e.g. ROOT_DIR) and all the globals (user defined variables, defined at runtime in the command line) are not available at that moment as the compiler is not yet setup. Therefore all these variables are replaced with the empty string. That's the bug that we see here.

I'd like to help resolve this but I'm not sure how to go about it. Any hints in a direction?

Added tests to cover this regression in the future in #2212, but no solution yet.

[pd93]

Thanks all. As @fechu mentioned, this is caused by #2113 which has been reverted in 8162b05 and released in v3.43.3. I'm going to close this issue and we should continue any discussion in #2108 and #2212.