Necessity of history query workaround due to "Rails bug which causes infinite loop"

[confiks]

In commit bf3a53f a workaround in the history method of adapters/active_record.rb was introduced that sorts the array outside of ActiveRecord when the transitions are already loaded. Otherwise a CollectionProxy would be returned, on which you can easily add more conditions and let the database do the work.

I was wondering if this workaround is actually required. I tested this with the first release release of Rails (v4.1.2) which contains said commit (rails/rails@b097ebe), and didn't encounter the infinite loop mentioned, nor did I using Rails v4.2.4.

[hmac]

I think this is a good point. It might be worth getting rid of that workaround in the next major release, and seeing if anyone is still hitting it.

[Sinjo]

I've opened #247 as a precursor to this. Once we've officially dropped support for old Ruby/Rails versions, we may be in a better place to do this.

The one caveat is that 4.2 is still supported, and we don't have a policy on compatibility for Rails patch releases. We'll also need to decide on one before we pull this workaround out.