Fix incorrect no-shadow warnings for TS enums (#315)

agerard-godaddy · web-flow · commit c2e15c22e251 · 2023-05-05T12:06:09.000-07:00
* fix: bad no-shadow warnings for TS enums
* chore: add changeset
diff --git a/.changeset/witty-guests-laugh.md b/.changeset/witty-guests-laugh.md
@@ -0,0 +1,6 @@
+---
+"eslint-config-godaddy-react-typescript": patch
+"eslint-config-godaddy-typescript": patch
+---
+
+Fix incorrect no-shadow warnings for TS enums
diff --git a/packages/eslint-config-godaddy-react-typescript/index.js b/packages/eslint-config-godaddy-react-typescript/index.js
@@ -21,7 +21,11 @@ module.exports = {
             args: 'after-used',
             ignoreRestSiblings: false
           }
-        ]
+        ],
+        // Disable the base rule and enable TypeScript version to avoid incorrect reports
+        // See https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-shadow.md
+        'no-shadow': 'off',
+        '@typescript-eslint/no-shadow': 'warn'
       }
     },
     {
diff --git a/packages/eslint-config-godaddy-typescript/index.js b/packages/eslint-config-godaddy-typescript/index.js
@@ -20,7 +20,11 @@ module.exports = {
             args: 'after-used',
             ignoreRestSiblings: false
           }
-        ]
+        ],
+        // Disable the base rule and enable TypeScript version to avoid incorrect reports
+        // See https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-shadow.md
+        'no-shadow': 'off',
+        '@typescript-eslint/no-shadow': 'warn'
       }
     }
   ]

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,11 @@ module.exports = {`
`21`	`21`	`args: 'after-used',`
`22`	`22`	`ignoreRestSiblings: false`
`23`	`23`	`}`
`24`		`- ]`
	`24`	`+ ],`
	`25`	`+ // Disable the base rule and enable TypeScript version to avoid incorrect reports`
	`26`	`+ // See https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-shadow.md`
	`27`	`+ 'no-shadow': 'off',`
	`28`	`+ '@typescript-eslint/no-shadow': 'warn'`
`25`	`29`	`}`
`26`	`30`	`},`
`27`	`31`	`{`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,11 @@ module.exports = {`
`20`	`20`	`args: 'after-used',`
`21`	`21`	`ignoreRestSiblings: false`
`22`	`22`	`}`
`23`		`- ]`
	`23`	`+ ],`
	`24`	`+ // Disable the base rule and enable TypeScript version to avoid incorrect reports`
	`25`	`+ // See https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-shadow.md`
	`26`	`+ 'no-shadow': 'off',`
	`27`	`+ '@typescript-eslint/no-shadow': 'warn'`
`24`	`28`	`}`
`25`	`29`	`}`
`26`	`30`	`]`