Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V-Sync swapchain image count setting is read after start #10720

Open
Kaleb-Reid opened this issue Feb 27, 2025 · 2 comments
Open

V-Sync swapchain image count setting is read after start #10720

Kaleb-Reid opened this issue Feb 27, 2025 · 2 comments
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository bug

Comments

@Kaleb-Reid
Copy link

Your Godot version: latest git commit at the time of writing

Issue description: I believe that the note saying that the property is only read when the project starts is incorrect, as after looking through the Vulkan driver at least, the setting is read every time the swap chain is resized. This could be forced immediately by running something like DisplayServer.window_set_vsync_mode(DisplayServer.window_get_vsync_mode()). I'm not sure of every case or the most elegant way to note it in the documentation, but I was under the impression that changing the swap chain image count would require a restart.

URL to the documentation page: https://docs.godotengine.org/en/latest/classes/class_projectsettings.html#class-projectsettings-property-rendering-rendering-device-vsync-swapchain-image-count

@Calinou Calinou added bug area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository labels Mar 7, 2025
@Calinou
Copy link
Member

Calinou commented Mar 7, 2025

cc @darksylinc

@darksylinc
Copy link

darksylinc commented Mar 7, 2025

It seems there were some differences between my PR godotengine/godot#80566 and @DarioSamo PR godotengine/godot#87340 which included (and superseeded) mine's.

If I'm reading this correctly, rendering/rendering_device/vsync/swapchain_image_count can now be changed at any point and will take effect on resize without having to worry about crashes or anything like that.

However the original remark still remains for rendering/rendering_device/vsync/frame_queue_size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository bug
Projects
None yet
Development

No branches or pull requests

3 participants