Add null check for SpriteFramesEditor's SpriteFrames

Author: chocola-mint

editor/plugins/sprite_frames_editor_plugin.cpp

@@ -280,6 +280,10 @@ void SpriteFramesEditor::_sheet_scroll_input(const Ref<InputEvent> &p_event) {
 }
 
 void SpriteFramesEditor::_sheet_add_frames() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	const Size2i frame_count = _get_frame_count();
 	const Size2i frame_size = _get_frame_size();
 	const Size2i offset = _get_offset();
@@ -688,6 +692,10 @@ void SpriteFramesEditor::_notification(int p_what) {
 }
 
 void SpriteFramesEditor::_file_load_request(const Vector<String> &p_path, int p_at_pos) {
+	if (frames.is_null()) {
+		return;
+	}
+
 	ERR_FAIL_COND(!frames->has_animation(edited_anim));
 
 	List<Ref<Texture2D>> resources;
@@ -747,6 +755,10 @@ Size2i SpriteFramesEditor::_get_separation() const {
 }
 
 void SpriteFramesEditor::_load_pressed() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	ERR_FAIL_COND(!frames->has_animation(edited_anim));
 	loading_scene = false;
 
@@ -762,6 +774,10 @@ void SpriteFramesEditor::_load_pressed() {
 }
 
 void SpriteFramesEditor::_paste_pressed() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	ERR_FAIL_COND(!frames->has_animation(edited_anim));
 
 	Ref<ClipboardSpriteFrames> clipboard_frames = EditorSettings::get_singleton()->get_resource_clipboard();
@@ -778,6 +794,10 @@ void SpriteFramesEditor::_paste_pressed() {
 }
 
 void SpriteFramesEditor::_paste_frame_array(const Ref<ClipboardSpriteFrames> &p_clipboard_frames) {
+	if (frames.is_null()) {
+		return;
+	}
+
 	if (p_clipboard_frames->frames.is_empty()) {
 		return;
 	}
@@ -805,6 +825,10 @@ void SpriteFramesEditor::_paste_frame_array(const Ref<ClipboardSpriteFrames> &p_
 }
 
 void SpriteFramesEditor::_paste_texture(const Ref<Texture2D> &p_texture) {
+	if (frames.is_null()) {
+		return;
+	}
+
 	float duration = 1.0;
 
 	EditorUndoRedoManager *undo_redo = EditorUndoRedoManager::get_singleton();
@@ -821,6 +845,10 @@ void SpriteFramesEditor::_paste_texture(const Ref<Texture2D> &p_texture) {
 }
 
 void SpriteFramesEditor::_copy_pressed() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	ERR_FAIL_COND(!frames->has_animation(edited_anim));
 
 	Vector<int> selected_items = frame_list->get_selected_items();
@@ -847,6 +875,10 @@ void SpriteFramesEditor::_copy_pressed() {
 }
 
 void SpriteFramesEditor::_empty_pressed() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	ERR_FAIL_COND(!frames->has_animation(edited_anim));
 
 	int from = -1;
@@ -872,6 +904,10 @@ void SpriteFramesEditor::_empty_pressed() {
 }
 
 void SpriteFramesEditor::_empty2_pressed() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	ERR_FAIL_COND(!frames->has_animation(edited_anim));
 
 	int from = -1;
@@ -897,6 +933,10 @@ void SpriteFramesEditor::_empty2_pressed() {
 }
 
 void SpriteFramesEditor::_up_pressed() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	ERR_FAIL_COND(!frames->has_animation(edited_anim));
 
 	Vector<int> selected_items = frame_list->get_selected_items();
@@ -943,6 +983,10 @@ void SpriteFramesEditor::_up_pressed() {
 }
 
 void SpriteFramesEditor::_down_pressed() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	ERR_FAIL_COND(!frames->has_animation(edited_anim));
 
 	Vector<int> selected_items = frame_list->get_selected_items();
@@ -989,6 +1033,10 @@ void SpriteFramesEditor::_down_pressed() {
 }
 
 void SpriteFramesEditor::_delete_pressed() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	ERR_FAIL_COND(!frames->has_animation(edited_anim));
 
 	Vector<int> selected_items = frame_list->get_selected_items();
@@ -1038,7 +1086,7 @@ void SpriteFramesEditor::_sync_animation() {
 }
 
 void SpriteFramesEditor::_select_animation(const String &p_name, bool p_update_node) {
-	if (frames.is_null() || !frames->has_animation(p_name)) {
+	if (!frames->has_animation(p_name)) {
 		return;
 	}
 	edited_anim = p_name;
@@ -1081,6 +1129,10 @@ static void _find_anim_sprites(Node *p_node, List<Node *> *r_nodes, Ref<SpriteFr
 }
 
 void SpriteFramesEditor::_animation_name_edited() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	if (updating) {
 		return;
 	}
@@ -1134,6 +1186,10 @@ void SpriteFramesEditor::_animation_name_edited() {
 }
 
 void SpriteFramesEditor::_rename_node_animation(EditorUndoRedoManager *undo_redo, bool is_undo, const String &p_filter, const String &p_new_animation, const String &p_new_autoplay) {
+	if (frames.is_null()) {
+		return;
+	}
+
 	List<Node *> nodes;
 	_find_anim_sprites(EditorNode::get_singleton()->get_edited_scene(), &nodes, Ref<SpriteFrames>(frames));
 
@@ -1188,6 +1244,10 @@ void SpriteFramesEditor::_animation_add() {
 }
 
 void SpriteFramesEditor::_animation_duplicate() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	if (updating) {
 		return;
 	}
@@ -1223,6 +1283,10 @@ void SpriteFramesEditor::_animation_duplicate() {
 }
 
 void SpriteFramesEditor::_animation_remove() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	if (updating) {
 		return;
 	}
@@ -1236,6 +1300,10 @@ void SpriteFramesEditor::_animation_remove() {
 }
 
 void SpriteFramesEditor::_animation_remove_confirmed() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	StringName new_edited;
 	List<StringName> anim_names;
 	frames->get_animation_list(&anim_names);
@@ -1276,6 +1344,10 @@ void SpriteFramesEditor::_animation_search_text_changed(const String &p_text) {
 }
 
 void SpriteFramesEditor::_animation_loop_changed() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	if (updating) {
 		return;
 	}
@@ -1294,6 +1366,10 @@ void SpriteFramesEditor::_animation_speed_resized() {
 }
 
 void SpriteFramesEditor::_animation_speed_changed(double p_value) {
+	if (frames.is_null()) {
+		return;
+	}
+
 	if (updating) {
 		return;
 	}
@@ -1308,6 +1384,10 @@ void SpriteFramesEditor::_animation_speed_changed(double p_value) {
 }
 
 void SpriteFramesEditor::_frame_list_gui_input(const Ref<InputEvent> &p_event) {
+	if (frames.is_null()) {
+		return;
+	}
+
 	const Ref<InputEventMouseButton> mb = p_event;
 
 	if (mb.is_valid()) {
@@ -1342,6 +1422,10 @@ void SpriteFramesEditor::_frame_list_gui_input(const Ref<InputEvent> &p_event) {
 }
 
 void SpriteFramesEditor::_menu_selected(int p_id) {
+	if (frames.is_null()) {
+		return;
+	}
+
 	switch (p_id) {
 		case MENU_SHOW_IN_FILESYSTEM: {
 			Ref<Texture2D> frame_texture = frames->get_frame_texture(edited_anim, right_clicked_frame);
@@ -1359,6 +1443,10 @@ void SpriteFramesEditor::_menu_selected(int p_id) {
 }
 
 void SpriteFramesEditor::_frame_list_item_selected(int p_index, bool p_selected) {
+	if (frames.is_null()) {
+		return;
+	}
+
 	if (updating) {
 		return;
 	}
@@ -1374,6 +1462,10 @@ void SpriteFramesEditor::_frame_list_item_selected(int p_index, bool p_selected)
 }
 
 void SpriteFramesEditor::_frame_duration_changed(double p_value) {
+	if (frames.is_null()) {
+		return;
+	}
+
 	if (updating) {
 		return;
 	}
@@ -1399,6 +1491,10 @@ void SpriteFramesEditor::_frame_duration_changed(double p_value) {
 }
 
 void SpriteFramesEditor::_zoom_in() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	// Do not zoom in or out with no visible frames
 	if (frames->get_frame_count(edited_anim) <= 0) {
 		return;
@@ -1412,6 +1508,10 @@ void SpriteFramesEditor::_zoom_in() {
 }
 
 void SpriteFramesEditor::_zoom_out() {
+	if (frames.is_null()) {
+		return;
+	}
+
 	// Do not zoom in or out with no visible frames
 	if (frames->get_frame_count(edited_anim) <= 0) {
 		return;
@@ -1645,6 +1745,10 @@ Ref<SpriteFrames> SpriteFramesEditor::get_sprite_frames() const {
 }
 
 Variant SpriteFramesEditor::get_drag_data_fw(const Point2 &p_point, Control *p_from) {
+	if (frames.is_null()) {
+		return false;
+	}
+
 	if (read_only) {
 		return false;
 	}
@@ -1718,6 +1822,10 @@ bool SpriteFramesEditor::can_drop_data_fw(const Point2 &p_point, const Variant &
 }
 
 void SpriteFramesEditor::drop_data_fw(const Point2 &p_point, const Variant &p_data, Control *p_from) {
+	if (frames.is_null()) {
+		return;
+	}
+
 	if (!can_drop_data_fw(p_point, p_data, p_from)) {
 		return;
 	}