Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful warnings in Windows export profile #104814

Open
KoBeWi opened this issue Mar 30, 2025 · 0 comments
Open

Unhelpful warnings in Windows export profile #104814

KoBeWi opened this issue Mar 30, 2025 · 0 comments

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Mar 30, 2025

Tested versions

4.5 dev1

System information

W10

Issue description

I noticed that when you export to Windows and put anything in version fields (File Version and Product Version, under Application category), you will very likely get these warnings:

Image

File Version expects a number in format 0.0.0.0 (i.e. 4 numbers separated by period). The warning does not tell you that. It just says the version is wrong and you are supposed to figure out the correct format. Luckily there is a description for this property, which points to documentation page, except the Godot's version validator does not even respect it xd
According to that page, ProductVersion can take non-numeric characters (there is 5.00.RC2 as an example). I'm not sure if even the period format is enforced in any way by the OS, but seems like Godot converts all bits into int, removing all non-numerics. Also you can e.g. put 1.2 into version, which will be automatically converted to 1.2.0.0. You can export the exe and the version shows in details correctly. Despite that, the warning will still say the version is wrong.

Product Version is more interesting. You can put any string into it (even though the specification is the same as for FileVersion) and it does get written correctly and displays in exe details. However the editor still expects 0.0.0.0 format strings and will show the warning if you don't follow it.

Steps to reproduce

  1. Create Windows export preset
  2. Put anything in File Version or Product Version

Minimal reproduction project (MRP)

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant