Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array of files is saved as uids in ProjectSettings since 4.4 #104818

Open
IceflowRE opened this issue Mar 30, 2025 · 2 comments
Open

Array of files is saved as uids in ProjectSettings since 4.4 #104818

IceflowRE opened this issue Mar 30, 2025 · 2 comments

Comments

@IceflowRE
Copy link
Contributor

IceflowRE commented Mar 30, 2025

Tested versions

System information

Godot v4.4.stable - Windows 11 (build 26100) - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1080 Ti (NVIDIA; 32.0.15.7216) - AMD Ryzen 9 7900X 12-Core Processor (24 threads)

Issue description

When adding a property to the ProjectSettings with TYPE_ARRAY, PROPERTY_HINT_ARRAY_TYPE and TYPE_STRING, PROPERTY_HINT_FILE, up to 4.4 the content was an array of elements using res://, since 4.4. this is an array of uids.

Why is this a bad breaking?

  1. Inconsistency: A single TYPE_STRING with PROPERTY_HINT_FILE is still saved using the path.
  2. The project settings are not upgraded by the Upgrade to UID routine. Means especially plugins have to consider both variants actively.
  3. There is no fallback anymore to the path variant, if the UID gets deleted, missing it is not possible to access the file anymore, or even know which file it was.
  4. If the UID changes the project setting is not automatically updated.

Steps to reproduce

Select files in ProjectSettings > General > Plugins > Testing.
The files are saved as uids in the project.godot.

Minimal reproduction project (MRP)

new_game_project.zip

@IceflowRE IceflowRE changed the title Array of files is saved as uids since 4.4 Array of files is saved as uids in ProjectSettings since 4.4 Mar 30, 2025
@IceflowRE

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants