Skip to content

Commit 6f713aa

Browse files
authored
Merge pull request #210 from gofiber/codex/2025-09-30-11-28-10
2 parents 66877cf + 6ae07a1 commit 6f713aa

File tree

3 files changed

+26
-1
lines changed

3 files changed

+26
-1
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ fiber upgrade [flags]
189189

190190
### Synopsis
191191

192-
Print the local and released version number of fiber
192+
Print the local and released version number of Fiber and the CLI
193193

194194
```bash
195195
fiber version [flags]

cmd/version.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ func versionRun(cmd *cobra.Command, _ []string) {
2424
var (
2525
cur, latest string
2626
err error
27+
cliLatest string
28+
cliErr error
2729
w = cmd.OutOrStdout()
2830
)
2931

@@ -37,6 +39,12 @@ func versionRun(cmd *cobra.Command, _ []string) {
3739
}
3840

3941
_, _ = fmt.Fprintf(w, "fiber version: %s (latest %s)\n", cur, latest)
42+
if cliLatest, cliErr = LatestCliVersion(); cliErr != nil {
43+
_, _ = fmt.Fprintf(w, "fiber cli version: %s (latest check failed: %v)\n", getVersion(), cliErr)
44+
return
45+
}
46+
47+
_, _ = fmt.Fprintf(w, "fiber cli version: %s (latest %s)\n", getVersion(), cliLatest)
4048
}
4149

4250
var (

cmd/version_test.go

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,13 @@ func Test_Version_Printer(t *testing.T) {
1919
clearHTTPCache()
2020

2121
httpmock.RegisterResponder(http.MethodGet, latestVersionURL, httpmock.NewBytesResponder(200, fakeVersionResponse))
22+
httpmock.RegisterResponder(http.MethodGet, latestCliVersionURL, httpmock.NewBytesResponder(200, fakeCliVersionResponse("1.2.3")))
2223

2324
out, err := runCobraCmd(versionCmd)
2425
require.NoError(t, err)
2526
at.Contains(out, "2.0.6")
27+
at.Contains(out, "fiber cli version:")
28+
at.Contains(out, "latest 1.2.3")
2629
})
2730

2831
t.Run("latest err", func(t *testing.T) {
@@ -36,6 +39,20 @@ func Test_Version_Printer(t *testing.T) {
3639
require.NoError(t, err)
3740
at.Contains(out, "no version")
3841
})
42+
43+
t.Run("cli latest err", func(t *testing.T) {
44+
httpmock.Activate()
45+
defer httpmock.DeactivateAndReset()
46+
clearHTTPCache()
47+
48+
httpmock.RegisterResponder(http.MethodGet, latestVersionURL, httpmock.NewBytesResponder(200, fakeVersionResponse))
49+
httpmock.RegisterResponder(http.MethodGet, latestCliVersionURL, httpmock.NewErrorResponder(errors.New("cli network error")))
50+
51+
out, err := runCobraCmd(versionCmd)
52+
require.NoError(t, err)
53+
at.Contains(out, "latest check failed")
54+
at.Contains(out, "cli network error")
55+
})
3956
}
4057

4158
func Test_Version_Current(t *testing.T) {

0 commit comments

Comments
 (0)