Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page.Render, RenderShortcodes names are confusing and should be replaced/deprecated #13472

Open
willfaught opened this issue Mar 5, 2025 · 0 comments

Comments

@willfaught
Copy link
Contributor

Page.Render sounds like it renders the page, but it doesn't, it renders the page using a named layout. It should have been called RenderLayout. RenderLayout would be less confusing.

Page.RenderShortcodes is confusing because it makes it sound like Page.Render doesn't render shortcodes. It should have been called Render. RenderDefault would be less confusing.

Perhaps we could deprecate the current names and add aliases for the less-confusing names. If v1/v2 ever ship, RenderDefault could be fixed to be Render.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant