Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: migrate CI from Kokoro to LUCI #71558

Open
h9jiang opened this issue Feb 4, 2025 · 0 comments
Open

x/pkgsite: migrate CI from Kokoro to LUCI #71558

h9jiang opened this issue Feb 4, 2025 · 0 comments
Labels
Friction Nuisances that make good candidates for our "friction" fix-it weeks Other None of the above. pkgsite
Milestone

Comments

@h9jiang
Copy link
Member

h9jiang commented Feb 4, 2025

What is the URL of the page with the issue?

N/A

What is your user agent?

N/A

Screenshot

No response

What did you do?

N/A

What did you see happen?

N/A

What did you expect to see?

As discussed with findleyr@, this could be a good candidate for the next FIX IT week so label FRICTION is added.

In golang/vscode-go#3533, we migrated the CI for vscode-go from Kokoro to LUCI. We want to migrate x/pkgsite as well.

From high level, here is what we did to migrate vscode-go from Kokoro to LUCI, there is also an internal document explaining this. But most CLs are being tracked in golang/vscode-go#3533:

  • Create builder for x/pkgsite in x/build luci-config branch.
  • Enable only the postsubmit in x/pkgsite. (Keep in mind, we do not want any CQ CL 642558, enable CQ means LUCI will be watching presubmit and it will trigger a test and the test will pass immediately)
  • Make sure the postsubmit are consistently passing. The development flow will be explained below.
  • Enable the presubmit in x/pkgsite.
  • Make sure LUCI-TryBot-Result=+1 is a submission requirement. (If its inherit from All-Project, we just need to remove overwriting.) So both LUCI and Kokoro +1 are required for submission.
  • Soak the env for a few weeks, remove the Kokoro +1 from submission requirement and remove Kokoro config.

When post submit are enabled, we might see test failing. So we need to submit CLs to fix the post submit test. However, we can only know if a CL is fixing the test after submission (because it's triggered as post submit). There is a way to trigger the post submit against an open CL

led get-builder golang/ci/x_vscode-go-go1.23-linux-amd64_docker | led edit-gerrit-cl https://go-review.git.corp.google.com/c/vscode-go/+/642917 | led launch

where golang/ci/x_vscode-go-go1.23-linux-amd64_docker is the builder name, https://go-review.git.corp.google.com/c/vscode-go/+/642917 is the link to the CL. after executing this command, a LUCI test will be triggered against the code in the CL. So we will know the result before we merge the code.

@h9jiang h9jiang added Friction Nuisances that make good candidates for our "friction" fix-it weeks pkgsite labels Feb 4, 2025
@h9jiang h9jiang added this to the Backlog milestone Feb 4, 2025
@gabyhelp gabyhelp added the Other None of the above. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Friction Nuisances that make good candidates for our "friction" fix-it weeks Other None of the above. pkgsite
Projects
None yet
Development

No branches or pull requests

2 participants