From 831ca2583262359594ebf0c0ec5508e8fcbaf46a Mon Sep 17 00:00:00 2001 From: Hongxiang Jiang Date: Thu, 30 Jan 2025 12:05:06 -0500 Subject: [PATCH] docs: replace kokoro with LUCI in contribution guide Add Kokoro to LUCI migration in CHANGELOG. For golang/vscode-go#3533 Change-Id: Ib121f3e9d8b9cb8e79016a5848596fc49d883545 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/646157 LUCI-TryBot-Result: Go LUCI kokoro-CI: kokoro Reviewed-by: Robert Findley --- CHANGELOG.md | 4 ++++ docs/contributing.md | 12 +++++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b9772468e9..74352e0121 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/). ## Unreleased +### Code Health + +* The testing framework is migrated from `Kokoro` to `LUCI`. The presubmit tests will be triggered against multiple go versions. + ## v0.45.0 (prerelease) Date: 2024-12-16 diff --git a/docs/contributing.md b/docs/contributing.md index a325633a96..9442080e40 100644 --- a/docs/contributing.md +++ b/docs/contributing.md @@ -183,12 +183,14 @@ Once you've sent out your change, a maintainer will take a look at your contribu ### Presubmit Test in CI When you mail your CL or upload a new patch to an existing CL, *AND* -you or a fellow contributor assigns the `Run-TryBot=+1` label in Gerrit, the test command defined in -`build/all.bash` will run by `Kokoro`, which is Jenkins-like Google infrastructure -for running Dockerized tests. `Kokoro` will post the result as a comment, and add its `TryBot-Result` -vote after each test run completes. +you or a fellow contributor assigns the `Commit-Queue=+1` label in Gerrit, all the +tests (including go test and typescript test) defined in vscode-go will be +triggered by `LUCI`. -To force a re-run of the Kokoro CI, add comment `kokoro rerun` to the CL. +`LUCI` will post the result as a comment, and add its `LUCI-TryBot-Result` vote +after all tests run completes. + +To force a re-run of the LUCI CI, re-assigns the `Commit-Queue=+1` label in Gerrit. [#vscode-dev]: https://gophers.slack.com/archives/CUWGEKH5Z [Gophers Slack]: https://invite.slack.golangbridge.org/