src/goDebugConfiguration: remove remote attach info pop-up

This change removes an informational pop-up at the start of remote attach session that was meant to announce to users that their dlv-dap setting was no longer ignored in that mode. In the past we defaulted to legacy regarding of the debugAdapter setting. Now that the intro period is over and the users also find this "announcement" confusing because it looks like an error, it is time to remove it. The users will be notified later in the session if their dlv version is too old to support remote attach and connection fails.

Fixes #2018

Change-Id: Iebecb3e7cb03d21a5a7b739c18554926a1e557f6
GitHub-Last-Rev: 3398531
GitHub-Pull-Request: #2097
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/391054
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Trust: Jamal Carvalho <[email protected]>

Author: polinasok

src/goDebugConfiguration.ts

@@ -172,13 +172,10 @@ export class GoDebugConfigurationProvider implements vscode.DebugConfigurationPr
 		}
 		if (debugConfiguration['debugAdapter'] === 'dlv-dap') {
 			if (debugConfiguration['mode'] === 'remote') {
-				// This is only possible if a user explicitely requests this combination. Let them, with a warning.
+				// This is only possible if a user explicitely requests this combination. Let them.
 				// They need to use dlv at version 'v1.7.3-0.20211026171155-b48ceec161d5' or later,
-				// but we have no way of detectng that with an external server.
-				this.showWarning(
-					'ignoreDlvDAPInRemoteModeWarning',
-					"Using new 'remote' mode with 'dlv-dap' to connect to an external `dlv --headless` server via DAP."
-				);
+				// but we have no way of detectng that with an external server ahead of time.
+				// If an earlier version is used, the attach will fail and a warning will warn about it.
 			} else if (debugConfiguration['port']) {
 				this.showWarning(
 					'ignorePortUsedInDlvDapWarning',