Test Explorer keeps obsolete method names when renaming test suite methods

[soerenkoehler]

Describe the bug

Use case: Using test explorer with Testify test suites and renaming suite methods.

Bug: Test explorer keeps old, obsolete and intermediate namings.

Expected behaviour: Test explorer shall mirror only the really existant test methods.

Point in question: How shall test explorer handle test suite methods in general?

Steps to reproduce the behavior:

1. (If necessary, enable Test Explorer.)
2. Open Test Explorer in side bar.
3. Import github.com/stretchr/testify/suite
4. Create a test suite and inside the suite a method func (s *TestSuite) TestFooBar() (screenshot 01).
5. Rename the test method to TestFooBarXyz via typing in the editor
6. Expect one renamed method entry in the test explorer.
7. Observe in test explorer four methods: one current, three obsolet (screenshot 02).

Screenshots

01 - method created

02 - method renamed

What version of Go, VS Code & VS Code Go extension are you using?

• Run go version to get version of Go from the VS Code integrated terminal.

go version go1.21.0 linux/amd64

• Run gopls -v version to get version of Gopls from the VS Code integrated terminal.

golang.org/x/tools/gopls v0.13.2
    golang.org/x/tools/gopls@v0.13.2 h1:Pyvx6MKvatbX3zzZmdGiFRfQZl0ohPlt2sFxO/5j6Ro=
    github.com/BurntSushi/toml@v1.2.1 h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak=
    github.com/google/go-cmp@v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38=
    github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
    golang.org/x/exp@v0.0.0-20220722155223-a9213eeb770e h1:+WEEuIdZHnUeJJmEUjyYC2gfUMj69yZXw17EnHg/otA=
    golang.org/x/exp/typeparams@v0.0.0-20221212164502-fae10dda9338 h1:2O2DON6y3XMJiQRAS1UWU+54aec2uopH3x7MAiqGW6Y=
    golang.org/x/mod@v0.12.0 h1:rmsUpXtvNzj340zd98LZ4KntptpfRHwpFOHG188oHXc=
    golang.org/x/sync@v0.3.0 h1:ftCYgMx6zT/asHUrPw8BLLscYtGznsLAnjq5RH9P66E=
    golang.org/x/sys@v0.10.0 h1:SqMFp9UcQJZa+pmYuAKjd9xq1f0j5rLcDIk0mj4qAsA=
    golang.org/x/text@v0.11.0 h1:LAntKIrcmeSKERyiOh0XMV39LXS8IE9UL2yP7+f5ij4=
    golang.org/x/tools@v0.11.2-0.20230810185051-cc6b5804b8cf h1:Oush7UwPamr2/iNeNFBuNFj89YyHn0YY69EKDdvANnk=
    golang.org/x/vuln@v0.0.0-20230110180137-6ad3e3d07815 h1:A9kONVi4+AnuOr1dopsibH6hLi1Huy54cbeJxnq4vmU=
    honnef.co/go/tools@v0.4.2 h1:6qXr+R5w+ktL5UkwEbPp+fEvfyoMPche6GkOpGHZcLc=
    mvdan.cc/gofumpt@v0.4.0 h1:JVf4NN1mIpHogBj7ABpgOyZc65/UUOkKQFkoURsz4MM=
    mvdan.cc/xurls/v2@v2.4.0 h1:tzxjVAj+wSBmDcF6zBB7/myTy3gX9xvi8Tyr28AuQgc=
go: go1.21.0

• Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders.

1.82.2
abd2f3db4bdb28f9e95536dfa84d8479f1eb312d
x64

• Check your installed extensions to get the version of the VS Code Go extension

v0.39.1
Last released 2023-7-17, 16:58:39
Last updated 2023-8-4, 17:57:36
Identifier golang.go

• Run Ctrl+Shift+P (Cmd+Shift+P on Mac OS) > Go: Locate Configured Go Tools command.

Checking configured tools....
GOBIN: undefined
toolsGopath: 
gopath: /home/soeren/go
GOROOT: /opt/go
PATH: /home/soeren/.vscode-server/bin/abd2f3db4bdb28f9e95536dfa84d8479f1eb312d/bin/remote-cli:/home/soeren/gems/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/opt/go/bin:/snap/bin

	go:	/opt/go/bin/go: go version go1.21.0 linux/amd64

	gotests:	/home/soeren/go/bin/gotests		(version: v1.6.0 built with go: go1.21.0)
	gomodifytags:	/home/soeren/go/bin/gomodifytags	(version: v1.16.0 built with go: go1.21.0)
	impl:		/home/soeren/go/bin/impl		(version: v1.1.0 built with go: go1.21.0)
	goplay:		/home/soeren/go/bin/goplay		(version: v1.0.0 built with go: go1.21.0)
	dlv:		/home/soeren/go/bin/dlv			(version: v1.21.0 built with go: go1.21.0)
	staticcheck:	/home/soeren/go/bin/staticcheck		(version: v0.4.3 built with go: go1.21.0)
	gopls:		/home/soeren/go/bin/gopls		(version: v0.13.2 built with go: go1.21.0)

go env
Workspace Folder (go-chdiff): /home/soeren/usrdev/go-chdiff
	GO111MODULE=''
	GOARCH='amd64'
	GOBIN=''
	GOCACHE='/home/soeren/.cache/go-build'
	GOENV='/home/soeren/.config/go/env'
	GOEXE=''
	GOEXPERIMENT=''
	GOFLAGS=''
	GOHOSTARCH='amd64'
	GOHOSTOS='linux'
	GOINSECURE=''
	GOMODCACHE='/home/soeren/go/pkg/mod'
	GONOPROXY=''
	GONOSUMDB=''
	GOOS='linux'
	GOPATH='/home/soeren/go'
	GOPRIVATE=''
	GOPROXY='https://proxy.golang.org,direct'
	GOROOT='/opt/go'
	GOSUMDB='sum.golang.org'
	GOTMPDIR=''
	GOTOOLCHAIN='auto'
	GOTOOLDIR='/opt/go/pkg/tool/linux_amd64'
	GOVCS=''
	GOVERSION='go1.21.0'
	GCCGO='gccgo'
	GOAMD64='v1'
	AR='ar'
	CC='gcc'
	CXX='g++'
	CGO_ENABLED='1'
	GOMOD='/home/soeren/usrdev/go-chdiff/go.mod'
	GOWORK=''
	CGO_CFLAGS='-O2 -g'
	CGO_CPPFLAGS=''
	CGO_CXXFLAGS='-O2 -g'
	CGO_FFLAGS='-O2 -g'
	CGO_LDFLAGS='-O2 -g'
	PKG_CONFIG='pkg-config'
	GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1772778533=/tmp/go-build -gno-record-gcc-switches'

Share the Go related settings you have added/edited

"go.testFlags": [
	"-v"
],
"go.testTimeout": "0s",
"go.editorContextMenuCommands": {
	"addTags": false,
	"testAtCursor": false,
	"generateTestForFunction": false,
	"testCoverage": false,
	"playground": false,
	"debugTestAtCursor": false
},
"go.survey.prompt": false,
"go.showWelcome": false,
"go.testExplorer.showOutput": false,
"go.testExplorer.packageDisplayMode": "nested",

[findleyr]

Thanks, this sounds like a bug. Leaving this untriaged as I'm not sure which milestone it should land in.

[firelizzard18]

This should be addressed by #3523