SA1019 does not flag deprecated interface methods

[ramiro-gamarra]

Hi everyone,

I'm working on a monorepo with lots of tech debt and lots of contributions. One way we are trying to fight off some anti-patterns is by deprecating some methods, and disallowing code to be merged if one such deprecated method is used. My hope was that we could replicate the behavior of SA1019 with something like ioutil, but with our own packages:

main.go:5:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)  
        "io/ioutil"

Unfortunately, I am not able to figure out a way to make it work like that. Using

➜  ~ golangci-lint --version
golangci-lint has version 1.50.1 built from 8926a95f on 2022-10-22T10:50:47Z

and package

package foo

type Foo interface {
	// DoNotUse should not be used.
	//
	// Deprecated: use something else.
	DoNotUse()
}

if I have a file such as

package main

import (
	"linttest/foo"
)

func main() {
	var f foo.Foo
	f.DoNotUse()
}

I get no warnings from golangci-lint as I had expected:

➜  linttest golangci-lint run -v
INFO [config_reader] Config search paths: [...] 
INFO [lintersdb] Active 7 linters: [errcheck gosimple govet ineffassign staticcheck typecheck unused] 
INFO [loader] Go packages loading at mode 575 (compiled_files|deps|imports|name|exports_file|files|types_sizes) took 123.9496ms 
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 296.7µs
INFO [linters_context/goanalysis] analyzers took 24.7512ms with top 10 stages: SA1012: 1.0023ms, SA5012: 921.5µs, typedness: 896.2µs, SA1004: 846µs, printf: 807.1µs, S1003: 763.1µs, SA4026: 725.2µs, nilness: 719.3µs, stringintconv: 704.9µs, buildir: 700.4µs
INFO [runner] processing took 6.5µs with stages: max_same_issues: 1µs, nolint: 600ns, max_from_linter: 500ns, skip_dirs: 400ns, skip_files: 400ns, path_prettifier: 300ns, sort_results: 300ns, cgo: 300ns, exclude: 300ns, diff: 300ns, filename_unadjuster: 300ns, path_prefixer: 200ns, source_code: 200ns, max_per_file_from_linter: 200ns, identifier_marker: 200ns, autogenerated_exclude: 200ns, path_shortener: 200ns, severity-rules: 200ns, exclude-rules: 200ns, uniq_by_line: 200ns
INFO [runner] linters took 6.2176ms with stages: goanalysis_metalinter: 6.1075ms
INFO File cache stats: 0 entries of total size 0B
INFO Memory: 3 samples, avg is 29.7MB, max is 32.4MB
INFO Execution took 159.2117ms

I see staticcheck as active. Am I doing something wrong or is this not really supported?

Thanks a lot for your help.