From 87293a33e666522f01d357fe593f53a10d66e947 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Przemys=C5=82aw=20Krzysztof=20Rekucki?= Date: Tue, 8 Jul 2025 15:38:50 +0200 Subject: [PATCH 1/3] fix: restore environment variable passing in init container Fixed inverted logic in init.c line 989 that prevented container environment variables (including PATH) from being passed to executed processes. The bug was introduced when `?:` operator was incorrectly changed to `? NULL :` during code formatting. Before: new_proc_args->envp ? NULL : environ After: new_proc_args->envp ? new_proc_args->envp : environ This ensures container-specified environment variables are properly preserved in the guest VM. --- runtime/init-container/src/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/init-container/src/init.c b/runtime/init-container/src/init.c index dc72f09c..317336be 100644 --- a/runtime/init-container/src/init.c +++ b/runtime/init-container/src/init.c @@ -986,7 +986,7 @@ static noreturn void child_wrapper(int parent_pipe[2], /* If execve returns we know an error happened. */ (void)execve(new_proc_args->bin, new_proc_args->argv, - new_proc_args->envp ? NULL : environ); + new_proc_args->envp ? new_proc_args->envp : environ); out: if (child_pipe != -1) From 40491179da4cbe7e638bbad2db57e68b4f18e0f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Przemys=C5=82aw=20Krzysztof=20Rekucki?= Date: Tue, 8 Jul 2025 15:41:29 +0200 Subject: [PATCH 2/3] chore: Release ya-runtime-vm version 0.5.3 --- Cargo.lock | 2 +- runtime/Cargo.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 39baafed..0b230c0f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2305,7 +2305,7 @@ dependencies = [ [[package]] name = "ya-runtime-vm" -version = "0.5.2" +version = "0.5.3" dependencies = [ "anyhow", "bollard-stubs", diff --git a/runtime/Cargo.toml b/runtime/Cargo.toml index 13c17c67..788d16cc 100644 --- a/runtime/Cargo.toml +++ b/runtime/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "ya-runtime-vm" -version = "0.5.2" +version = "0.5.3" authors = ["Golem Factory "] edition = "2021" license = "GPL-3.0" From bc328763ec9514f9b94bb565b69048fccd0ef082 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Przemys=C5=82aw=20Krzysztof=20Rekucki?= Date: Tue, 8 Jul 2025 17:00:02 +0200 Subject: [PATCH 3/3] fix: update deprecated GitHub Actions to latest versions - Update actions/checkout from v1/v2 to v4 - Update actions/cache from v1 to v4 - Update actions/github-script from v3.0/0.9.0 to v7 This resolves CI failures caused by deprecated action versions. --- .github/workflows/build.yml | 10 +++++----- .github/workflows/release.yml | 12 ++++++------ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c4e74cc2..2fa0080b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -25,7 +25,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v4 - name: Install Rust ${{ env.rust_stable }} uses: actions-rs/toolchain@v1 @@ -33,7 +33,7 @@ jobs: toolchain: ${{ env.rust_stable }} - name: Cache cargo registry - uses: actions/cache@v1 + uses: actions/cache@v4 with: path: ~/.cargo/registry key: ${{ runner.os }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }} @@ -41,7 +41,7 @@ jobs: ${{ runner.os }}-cargo-registry- - name: Cache cargo index - uses: actions/cache@v1 + uses: actions/cache@v4 with: path: ~/.cargo/git key: ${{ runner.os }}-cargo-index-${{ hashFiles('**/Cargo.lock') }} @@ -49,7 +49,7 @@ jobs: ${{ runner.os }}-cargo-index- - name: Cache cargo build - uses: actions/cache@v1 + uses: actions/cache@v4 with: path: target key: ${{ runner.os }}-cargo-build-target1-${{ hashFiles('**/Cargo.lock') }} @@ -68,7 +68,7 @@ jobs: args: --all-targets --all-features --workspace -- -D warnings - name: Cache vcpkg's artifacts - uses: actions/cache@v1 + uses: actions/cache@v4 if: matrix.os == 'windows-latest' with: path: c:/vcpkg/installed diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e1a12d26..fdafdea3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -16,7 +16,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Create Release - uses: actions/github-script@v3.0 + uses: actions/github-script@v7 with: github-token: ${{secrets.GITHUB_TOKEN}} script: | @@ -51,7 +51,7 @@ jobs: steps: - name: Install Musl run: sudo apt-get install -y musl-tools musl autoconf gperf libtool automake - - uses: actions/checkout@v1 + - uses: actions/checkout@v4 - name: Make run: | musl-gcc -v @@ -75,7 +75,7 @@ jobs: env: OPENSSL_STATIC: 1 steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v4 with: lfs: true - uses: actions/download-artifact@v4 @@ -99,7 +99,7 @@ jobs: sudo apt-get install -y musl-tools musl - name: Get upload url id: release_upload_url - uses: actions/github-script@0.9.0 + uses: actions/github-script@v7 with: github-token: ${{secrets.GITHUB_TOKEN}} result-encoding: string @@ -165,7 +165,7 @@ jobs: steps: - name: Get upload url id: release_upload_url - uses: actions/github-script@0.9.0 + uses: actions/github-script@v7 with: github-token: ${{secrets.GITHUB_TOKEN}} result-encoding: string @@ -179,7 +179,7 @@ jobs: console.log(release.data.upload_url); return release.data.upload_url - name: Check out repository - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: lfs: true - uses: actions/download-artifact@v4