Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of NLLoss and its variant #1124

Open
Saanidhyavats opened this issue Oct 29, 2024 · 2 comments
Open

Addition of NLLoss and its variant #1124

Saanidhyavats opened this issue Oct 29, 2024 · 2 comments

Comments

@Saanidhyavats
Copy link

Saanidhyavats commented Oct 29, 2024

@vroulet I was thinking that addition of NLLoss (https://pytorch.org/docs/stable/generated/torch.nn.NLLLoss.html), PoissonNLLLoss(https://pytorch.org/docs/stable/generated/torch.nn.PoissonNLLLoss.html) and GaussianNLLLoss(https://pytorch.org/docs/stable/generated/torch.nn.GaussianNLLLoss.html) in this library will be useful.

@vroulet
Copy link
Collaborator

vroulet commented Nov 2, 2024

Hello @Saanidhyavats,
It makes sense indeed. Would you like to contribute to such a PR?
Make sure to take a look at the other losses to see some template and also to see if these losses could be instantiated through other losses (I don't think so from a quick look but better to verify thoroughly).

@Saanidhyavats
Copy link
Author

Sure I will create a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants