-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove tensorflow as dependency for the examples #656
Comments
Anyone working on this? if not, I'd be happy to work on it. |
All yours @mmhamdy ! |
hey @mmhamdy , any progress on this? I might have some cycles to work on this issue next week if it's not yet solved |
Hi @fabianp, sorry for taking that long, January was such a MONTHFUL😅 for me! But anyway, I'll submit a PR in a couple of days. I was leaving
So, we are getting a TF-free dataset but we still need TF to process it. That's nice, but still not that helpful. I used The other datasets are fine. Now, the examples notebooks that use TF and TFDS are:
The first 4 examples use MNIST, and So, I think I'm going to start with Thank you, and sorry for the long reply. Was just thinking out loud. |
Excellent, and thanks for the update! I'm trying to push for this as I'd like to test on Python 3.12 but unfortunately TF is blocking us from doing so 😞 (#714)
That's still an improvement 😄 . Let's take it step by step and merge this part, then we can take care of the processing in a separate PR :-)
huh, that's annoying. Could you link this issue here? perhaps I can take a look into it or ask around.
yeah, let's start with one and take it from there. It's always easier to review a small PR and iterate on it rather than making huge changes to the codebase on one go.
Thanks to you! I think the tag "good first issue" was over-optimistic on my end 😅 , this is really a quite difficult issue! |
Nice catch, I've opened #767 to track this |
Yeah, but maybe there is still little hope here. This is the issue
Sure, I'll finish the
Yeah, I agree (just remembered I intended to do it while migrating the jaxopt example 😅😅). But, to be honest, I'm really enjoying it. |
Currently we're importing tensorflow for some examples such as in https://optax.readthedocs.io/en/latest/_collections/examples/cifar10_resnet.html.
It should be possible to avoid this import and instead rely exclusively on tfds and (if necessary grain)
See for example https://www.tensorflow.org/datasets/tfless_tfds on how to import tfds datasets without tensorflow.
The text was updated successfully, but these errors were encountered: