From c5625a6d00849679a4c52e99ca3715917c3eec11 Mon Sep 17 00:00:00 2001 From: Peter Date: Tue, 2 Jul 2024 20:47:52 +0200 Subject: [PATCH 1/2] Fix bug in time convention application --- weatherbench2/schema.py | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/weatherbench2/schema.py b/weatherbench2/schema.py index c037c1b..5159ed0 100644 --- a/weatherbench2/schema.py +++ b/weatherbench2/schema.py @@ -29,19 +29,19 @@ def apply_time_conventions( forecast = forecast.copy() if 'prediction_timedelta' in forecast.coords: forecast = forecast.rename({'prediction_timedelta': 'lead_time'}) - if by_init: - # Need to rename time dimension because different from time dimension in - # truth dataset - forecast = forecast.rename({'time': 'init_time'}) - valid_time = forecast.init_time + forecast.lead_time - forecast.coords['valid_time'] = valid_time - assert not hasattr( - forecast, 'time' - ), f'Forecast should not have time dimension at this point: {forecast}' - else: - init_time = forecast.time - forecast.lead_time - forecast.coords['init_time'] = init_time - return forecast + if by_init: + # Need to rename time dimension because different from time dimension in + # truth dataset + forecast = forecast.rename({'time': 'init_time'}) + valid_time = forecast.init_time + forecast.lead_time + forecast.coords['valid_time'] = valid_time + assert not hasattr( + forecast, 'time' + ), f'Forecast should not have time dimension at this point: {forecast}' + else: + init_time = forecast.time - forecast.lead_time + forecast.coords['init_time'] = init_time + return forec ast ALL_3D_VARIABLES = ( From f36f310e34485db47c2ff5e63db832d76bf919e7 Mon Sep 17 00:00:00 2001 From: Peter Date: Tue, 2 Jul 2024 20:52:18 +0200 Subject: [PATCH 2/2] fix typo --- weatherbench2/schema.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/weatherbench2/schema.py b/weatherbench2/schema.py index 5159ed0..9a75b99 100644 --- a/weatherbench2/schema.py +++ b/weatherbench2/schema.py @@ -41,7 +41,7 @@ def apply_time_conventions( else: init_time = forecast.time - forecast.lead_time forecast.coords['init_time'] = init_time - return forec ast + return forecast ALL_3D_VARIABLES = (