Skip to content

Conversation

@arjunvijaygoogle
Copy link

Welcome to Mosaic RAG AI, a state-of-the-art system architecture designed to transform your organization's data archive into a dynamic, interactive knowledge base. This system moves beyond simple keyword search, allowing users to have natural language conversations with their data, regardless of the format: video, audio, images, PDFs, and text.

Want to add the new Sample agent mosaic RAG
https://github.com/arjunvijaygoogle/mosaic-rag-ai/tree/main

@ivanmkc
Copy link
Collaborator

ivanmkc commented Aug 9, 2025

@gemini-cli /review

@github-actions
Copy link

github-actions bot commented Aug 9, 2025

There is a problem with the Gemini CLI PR review. Please check the action logs for details.

@ivanmkc
Copy link
Collaborator

ivanmkc commented Aug 11, 2025

@gemini-cli /review

@github-actions
Copy link

There is a problem with the Gemini CLI PR review. Please check the action logs for details.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR adds the mosaic-rag-ai agent as a git submodule. The change itself is small, but it has implications for the build process and future code reviews, which I've highlighted in the inline comment.

🔍 General Feedback

  • The use of a submodule is a good way to incorporate a separate project into this repository of samples.
  • Please ensure the CI/CD pipeline is updated to handle submodules.

@@ -0,0 +1 @@
Subproject commit bbc575a96254a319f199d928844bd7e056c63521

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 This change introduces a git submodule. While this is a valid way to include external code, please ensure that the CI/CD pipeline is configured to handle submodules correctly by running git submodule update --init --recursive during the build process. Also, be aware that future updates to the submodule will only be reflected as a commit hash change in this repository, which can make code reviews less transparent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants