[BUG] Invalid Pointer Dereference due to std::vector auto-resizing in Memory Manager Result push_back

[CncGpp]

Describe the bug
When a Memory Manager class is registered, the results of each iteration are appended to an std::vector, and a pointer to the newly added element is used as a reference thereafter.

benchmark/src/benchmark_runner.cc

Lines 434 to 435 in 8d4fdd6

	memory_results.push_back(MemoryManager::Result());
	MemoryManager::Result* memory_result = &memory_results.back();

However, when the vector automatically resizes, these pointers become invalid, leading to corrupted statistical measurements.
The problem only occurs if the number of repetitions is greater than one.

To reproduce
Steps to reproduce the behavior:

1. Register a Memory Manager class
2. Run any benchmark with at least 3 repetitions
3. User the Json reporter to see the corrupted memory related stats.

Expected behavior
Pointers to stored values should remain valid, or the implementation should ensure they are updated correctly when the vector reallocates.

Additional context
Possible fixes:

• Use std::list or instead of std::vector to avoid reallocation issues.
• Store indices instead of pointers if possible.
• Reserve GetNumRepeats() values to the std::vector to ensure no automatic growth is performed.

[LebedevRI]

Please can you show the ASan output?

[LebedevRI]

Ah yes, CreateRunReport() is of course wrong.
BenchmarkReporter::Run should store MemoryManager::Result, not the pointer to it.