Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting errors in src/local/butler/scripts/setup.py #4051

Open
jonathanmetzman opened this issue Jun 20, 2024 · 2 comments
Open

Fix linting errors in src/local/butler/scripts/setup.py #4051

jonathanmetzman opened this issue Jun 20, 2024 · 2 comments
Assignees

Comments

@jonathanmetzman
Copy link
Collaborator

They look like they are from the python upgrade:

src/local/butler/scripts/setup.py:372:17: E1101: Instance of 'MetricServiceClient' has no 'project_path' member (no-member)
src/local/butler/scripts/setup.py:385:8: E1121: Too many positional arguments for method call (too-many-function-args)
src/local/butler/scripts/setup.py:389:8: E1121: Too many positional arguments for method call (too-many-function-args)

@vitorguidi
Copy link
Collaborator

There is a migration guide to monitoring >=2.0, from this stack overflow post. Gonna look into this

@vitorguidi
Copy link
Collaborator

#4062

Verified the setup.py butler script works, this should do the trick

python butler.py run setup --config-dir ../clusterfuzz-config/configs/internal --non-dry-run
...

Done

Please remember to run the migration individually on all projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants