Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible return types for storage.get between local filesystem and GCS implementation #4357

Open
vitorguidi opened this issue Oct 24, 2024 · 0 comments
Assignees

Comments

@vitorguidi
Copy link
Collaborator

As per GCP docs, the GET method returns a datetime object serialized as UTC string, for the last update time. Thus, the implementation for GCS in storage.get returns a string for ['updated'].

The local filesystem implementation, however, returns a raw datetime object. This generates inconsistency for two concrete implementations of the same contract.

The issue was noticed in #4341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant