Pass --renormalize during git add to fix LFS usage in destination repo
#301
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
TY! Left a comment - the CLA will prevent any imports until signed, sorry about that. |
- "false" by default - value passed to call to GitOrigin.newGitOrigin, just like for github_origin - allows for LFS usage with any Git backend that supports LFS, e.g. GitLab Co-authored-by: Ashraful Islam <[email protected]>
- `renormalize` field is "false" by default - sets `renormalize` field to true - if `renormalize` is set to true, "--renormalize" argument is appended to the `git add` command. Co-authored-by: Ashraful Islam <[email protected]>
- enables use of Git LFS in git destinations Co-authored-by: Ashraful Islam <[email protected]>
1-ashraful-islam
force-pushed
the
presage
branch
from
f04fad5
to
b28f11b
Compare
|
@hsudhof I guess it doesn't have to be a single MR. We were getting Copybara to work on this scenario: It required both of these changes to actually go through, but if you think they are orthogonal, I can make two separate MRs. |
|
@hsudhof I'll wait for your feedback before moving forward with separating this into two PRs. |
This reverts commit a787216.
|
@hsudhof we removed the enabling of the lfs parameter from the current PR, we'll make a separate one for enabling LFS in non-GitHub origins after we're done with this one. |
Algomorph
changed the title
--renormalize during git add to fix LFS usage in destination repo
…neral option is used Co-authored-by: Ashraful Islam <[email protected]> - fix on very first (--force) revision
| alternate.add().force().all().run(); | ||
| }else{ | ||
| alternate.add().force().renormalize().all().run(); | ||
| } |
There was a problem hiding this comment.
We discovered that, on initial sync of a branch w/ --force flag usage in global options, adding --renormalize results in a situation where no new files are added to that initial destination commit. Hence the conditional. Perhaps this isn't the best design; if so, we request reviewer's input on what can be a better design.
- Allow the user to setenable_lfs = trueas a parameter of regulargit.origin(as opposed to onlygit.github_origin), thereby extending support to GitLab LFS origins (set toenable_lfs = falseby default, so change is backwards-compatible to all existing workflows and compatible with non-lfs-enabled Git repositories).--renormalizeduringgit add, which fixes LFS on the target repo (enabling coupling e.g. GitLab origins w/ LFS to GitHub destinations with LFS and similar user stories)Fixes #277 andaddresses #60 (comment)