You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Commit 54ad644 removed a test because the required version of Windows SDK to build Dawn is 22621. However, GitHub Action Windows runner uses SDK version 20348 by default.
This PR uses [fbactions/setup-winsdk@v2](https://github.com/fbactions/setup-winsdk) to install the target version of Windows SDK, but this is not enough so we also add env variable to force SDK detection. Both env variables and cmake variable seem to be required, the former are used by DXC's `FindD3D12` script and others are for CMake's generic SDK detection.
Example of successful CI run: https://github.com/eliemichel/dawn-prebuilt/actions/runs/11861028908/job/33057504211
This is an imported pull request from
#23
GITHUB_PR_HEAD_SHA=dbaa1dcae87e7c5fd71d034c900eec979099388b
ORIGINAL_AUTHOR=Elie Michel <[email protected]>
GitOrigin-RevId: 1fbce97
Change-Id: I4b5a57c5063c3deff9f4a632ee553bc779dccbb4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/215215
Reviewed-by: Corentin Wallez <[email protected]>
Commit-Queue: Corentin Wallez <[email protected]>
Reviewed-by: dan sinclair <[email protected]>
0 commit comments