Theme and appearance rework.

- Remove table vertical header.
- Consistent accent color across application.
- Native system theme on KDE

Author: hysw

ui/command_buffer_model.cpp

@@ -20,6 +20,7 @@
 
 #include <iostream>
 #include <sstream>
+#include "color_utils.h"
 #include "dive_core/command_hierarchy.h"
 #include "dive_tree_view.h"
 
@@ -92,7 +93,7 @@ QVariant CommandBufferModel::data(const QModelIndex &index, int role) const
 
     uint64_t node_index = index.internalId();
     if (role == Qt::ForegroundRole && IsSelected(node_index))
-        return QColor(255, 128, 128);
+        return GetTextAccentColor();
 
     if (role != Qt::DisplayRole)
         return QVariant();
@@ -457,4 +458,4 @@ bool CommandBufferModel::IsSelected(uint64_t node_index) const
     uint32_t bit_element = node_index % 8;
     uint8_t  mask = 0x1 << bit_element;
     return (m_node_is_selected_bit_list[array_index] & mask) != 0;
-}
+}

ui/command_model.cpp

@@ -18,6 +18,7 @@
 #include <QStringList>
 #include <QTreeWidget>
 
+#include "color_utils.h"
 #include "dive_core/command_hierarchy.h"
 
 static_assert(sizeof(void *) == sizeof(uint64_t),
@@ -86,7 +87,7 @@ QVariant CommandModel::data(const QModelIndex &index, int role) const
                 if (marker_type == Dive::CommandHierarchy::MarkerType::kInsert ||
                     marker_type == Dive::CommandHierarchy::MarkerType::kBeginEnd)
                 {
-                    return QVariant(QBrush(QColor(85, 139, 47)));  // Shade of green
+                    return QVariant(QBrush(GetTextAccentColor()));
                 }
             }
         }

ui/dive_application.cpp

@@ -0,0 +1,30 @@
+/*
+ Copyright 2025 Google LLC
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+#include "dive_application.h"
+
+bool DiveApplication::event(QEvent* e)
+{
+    if (e->type() == QEvent::ApplicationPaletteChange)
+    {
+        if (m_style_sheet)
+        {
+            // Re-apply style sheet, so palette change is propagated.
+            setStyleSheet(*m_style_sheet);
+        }
+    }
+    return QApplication::event(e);
+}

ui/dive_application.h

@@ -0,0 +1,41 @@
+/*
+ Copyright 2025 Google LLC
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+#pragma once
+
+#include <optional>
+
+#include <QApplication>
+#include <QEvent>
+#include <QString>
+
+class DiveApplication : public QApplication
+{
+    Q_OBJECT
+public:
+    using QApplication::QApplication;
+    void SetStyleSheet(const QString& style_sheet)
+    {
+        m_style_sheet = style_sheet;
+        setStyleSheet(style_sheet);
+    }
+
+protected:
+    virtual bool event(QEvent* e) Q_DECL_OVERRIDE;
+
+private:
+    std::optional<QString> m_style_sheet;
+};

ui/main.cpp

@@ -20,12 +20,14 @@
 #include <QDir>
 #include <QFile>
 #include <QFileInfo>
+#include <QProcessEnvironment>
 #include <QSplashScreen>
 #include <QStyleFactory>
 #include <QTimer>
 #include <cstdio>
 #include <fcntl.h>
 #include <iostream>
+#include "dive_application.h"
 #include "dive_core/common.h"
 #include "dive_core/pm4_info.h"
 #include "application_controller.h"
@@ -247,29 +249,52 @@ int main(int argc, char *argv[])
 
     // Try setting "Fusion" style. If not found, set "Windows".
     // And if that's not found, default to whatever style the factory provides.
-    if (!SetApplicationStyle("Fusion"))
+    bool use_default_style = false;
+
+    QProcessEnvironment env = QProcessEnvironment::systemEnvironment();
+    QString             desktopEnvironment = env.value("XDG_CURRENT_DESKTOP");
+    if (desktopEnvironment.contains("KDE", Qt::CaseInsensitive))
+    {
+        use_default_style = true;
+    }
+
+    if (!use_default_style)
     {
-        if (!SetApplicationStyle("Windows"))
+        if (!SetApplicationStyle("Fusion"))
         {
-            if (!QStyleFactory::keys().empty())
+            if (!SetApplicationStyle("Windows"))
             {
-                SetApplicationStyle(QStyleFactory::keys()[0]);
+                if (!QStyleFactory::keys().empty())
+                {
+                    SetApplicationStyle(QStyleFactory::keys()[0]);
+                }
             }
         }
     }
 
     Dive::RegisterCustomMetaType();
 
     QApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
-    QApplication app(argc, argv);
+    DiveApplication app(argc, argv);
     app.setWindowIcon(QIcon(":/images/dive.ico"));
-    SetDarkMode(app);
 
-    // Load and apply the style sheet
-    QFile style_sheet(":/stylesheet.qss");
-    style_sheet.open(QFile::ReadOnly);
-    QString style(style_sheet.readAll());
-    app.setStyleSheet(style);
+    if (!use_default_style)
+    {
+        SetDarkMode(app);
+        // Load and apply the style sheet
+        QFile style_sheet(":/stylesheet.qss");
+        style_sheet.open(QFile::ReadOnly);
+        QString style(style_sheet.readAll());
+        app.SetStyleSheet(style);
+    }
+    else
+    {
+        // Load and apply the style sheet
+        QFile style_sheet(":/stylesheet_adaptive.qss");
+        style_sheet.open(QFile::ReadOnly);
+        QString style(style_sheet.readAll());
+        app.SetStyleSheet(style);
+    }
 
     // Display splash screen
     QSplashScreen *splash_screen = new QSplashScreen();
@@ -285,6 +310,7 @@ int main(int argc, char *argv[])
     {
         QObject::connect(main_window, &MainWindow::FileLoaded, main_window, &MainWindow::close);
     }
+    main_window->SetUseDefaultStyle(use_default_style);
 
     if (!controller.InitializePlugins())
     {

ui/main_window.cpp

@@ -1637,7 +1637,7 @@ void MainWindow::CreateActions()
 {
     // Open file action
     m_open_action = new QAction(tr("&Open"), this);
-    m_open_action->setIcon(QIcon(":/images/open.png"));
+    m_open_action->setIcon(QApplication::style()->standardIcon(QStyle::SP_DialogOpenButton));
     m_open_action->setShortcuts(QKeySequence::Open);
     m_open_action->setStatusTip(tr("Open an existing capture"));
     connect(m_open_action, &QAction::triggered, this, &MainWindow::OnOpenFile);
@@ -1652,7 +1652,7 @@ void MainWindow::CreateActions()
     // Save file action
     m_save_action = new QAction(tr("&Save"), this);
     m_save_action->setStatusTip(tr("Save the current capture"));
-    m_save_action->setIcon(QIcon(":/images/save.png"));
+    m_save_action->setIcon(QApplication::style()->standardIcon(QStyle::SP_DialogSaveButton));
     m_save_action->setShortcut(QKeySequence::Save);
     m_save_action->setEnabled(false);
     connect(m_save_action, &QAction::triggered, this, &MainWindow::OnSaveCapture);
@@ -1670,6 +1670,7 @@ void MainWindow::CreateActions()
     for (auto &action : m_recent_file_actions)
     {
         action = new QAction(this);
+        action->setIcon(QApplication::style()->standardIcon(QStyle::SP_FileIcon));
         action->setVisible(false);
         connect(action, SIGNAL(triggered()), this, SLOT(OpenRecentFile()));
     }
@@ -1819,7 +1820,10 @@ void MainWindow::CreateStatusBar()
 {
     // Create status bar on the main window.
     m_status_bar = new QStatusBar(this);
-    m_status_bar->setStyleSheet("background:#D0D0D0; color:#282828");
+    if (!m_use_default_style)
+    {
+        m_status_bar->setStyleSheet("background:#D0D0D0; color:#282828");
+    }
     setStatusBar(m_status_bar);
 }
 

ui/main_window.h

@@ -125,6 +125,8 @@ class MainWindow : public QMainWindow
     ~MainWindow();
     bool LoadFile(const std::string &file_name, bool is_temp_file = false, bool async = true);
 
+    void SetUseDefaultStyle(bool use_default_style) { m_use_default_style = use_default_style; }
+
 protected:
     virtual void closeEvent(QCloseEvent *closeEvent) Q_DECL_OVERRIDE;
 
@@ -238,6 +240,8 @@ private slots:
     CorrelationTarget            target);
 
     ApplicationController &m_controller;
+    
+    bool m_use_default_style = false;
 
     QMenu         *m_file_menu;
     QMenu         *m_recent_captures_menu;

ui/resources.qrc

@@ -17,8 +17,9 @@
         <file>images/dive.png</file>
         <file>images/dive.ico</file>
         <file>stylesheet.qss</file>
+        <file>stylesheet_adaptive.qss</file>
         <file>images/filter.png</file>
         <file>images/analyze.png</file>
         <file>images/copy.png</file>
     </qresource>
-</RCC>
+</RCC>

ui/stylesheet_adaptive.qss

@@ -0,0 +1,41 @@
+/* QTreeView style */
+
+QTreeView {
+    show-decoration-selected: 1;
+}
+
+QTreeView::branch:has-siblings:!adjoins-item {
+    border-image: url(\":/images/vline.png\") 0;
+}
+
+QTreeView::branch:has-siblings:adjoins-item {
+    border-image: url(\":/images/branch_more.png\") 0;
+}
+
+QTreeView::branch:!has-children:!has-siblings:adjoins-item {
+    border-image: url(\":/images/branch_end.png\") 0;
+}
+
+QTreeView::branch:has-children:!has-siblings:closed,
+QTreeView::branch:closed:has-children:has-siblings {
+    border-image: none;
+    image: url(\":/images/branch_closed.png\");
+}
+
+QTreeView::branch:open:has-children:!has-siblings,
+QTreeView::branch:open:has-children:has-siblings  {
+    border-image: none;
+    image: url(\":/images/branch_open.png\");
+}
+
+/* Style for the hover help label */
+QLabel#hoverHelpLabel {
+    background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1, stop: 0 #e7effd, stop: 1 #cbdaf1);
+    border-radius: 5px;
+    color: #000;
+    padding: 3px;
+}
+
+QLabel#propertyPanelLabel {
+    font - family : Arial, Helvetica, sans - serif;
+}